Checkbox

Merge ~rickwu4444/checkbox/+git/checkbox-configure:fix-checkbox-classic-cannot-find-checkbox-cli-wrapper into ~checkbox-dev/checkbox/+git/checkbox-configure:master

  1. Git
  2. lp:~rickwu4444/checkbox/+git/checkbox-configure
  3. fix-checkbox-classic-cannot-find-checkbox-cli-wrapper
  4. Merge into master
Proposed by Rick Wu
Status: Merged
Approved by: Vic Liu
Approved revision: 2c6558fbc4b277c90ddd83cb3862b0029bf282a7
Merged at revision: 931e3a7e56534ff43ed2c2bd4a37b8d0fb80013a
Proposed branch: ~rickwu4444/checkbox/+git/checkbox-configure:fix-checkbox-classic-cannot-find-checkbox-cli-wrapper
Merge into: ~checkbox-dev/checkbox/+git/checkbox-configure:master
Diff against target: 12 lines (+1/-1)
1 file modified
launchers/wrapper_local.in_classic (+1/-1)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Approve
Sylvain Pineau (community) Needs Fixing
Pierre Equoy Approve
Maciej Kisielewski Pending
Review via email: mp+417024@code.qastaging.launchpad.net

Commit message

Fix: Checkbox classic can not find checkbox-cli-wrapper

Checkbox will complain can't find "checkbox-cli-wrapper" in "/usr/bin/env" after execute "checkbox-classic.test-runner". Therefor, add "$SNAP/bin" into global PATH to fix this problem. We thinks if this fix can merge into "checkbox-configure", then QA won't need to fix this for individual project.

To post a comment you must log in.
Revision history for this message
Pierre Equoy (pieq) wrote :

+1, as we already discussed for another project.

review: Approve
Revision history for this message
Jonathan Cave (jocave) wrote :

Please match the ordering of entries in https://git.launchpad.net/checkbox/tree/launchers/wrapper_local?h=series_classic20#n34

(place it before /snap/bin)

review: Needs Fixing
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Should be indeed identical to https://git.launchpad.net/checkbox/tree/launchers/wrapper_local#n34 (master branch contains the classic wrapper)

review: Needs Fixing
Revision history for this message
Rick Wu (rickwu4444) wrote :

@All,
Thanks for the review, and I fixed the path.

Revision history for this message
Jonathan Cave (jocave) wrote :

Thanks +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: