Checkbox

Merge ~rickwu4444/checkbox/+git/checkbox-configure:modify-for-provider-ce-oem into ~checkbox-dev/checkbox/+git/checkbox-configure:master

  1. Git
  2. lp:~rickwu4444/checkbox/+git/checkbox-configure
  3. modify-for-provider-ce-oem
  4. Merge into master
Proposed by Rick Wu
Status: Rejected
Rejected by: Rick Wu
Proposed branch: ~rickwu4444/checkbox/+git/checkbox-configure:modify-for-provider-ce-oem
Merge into: ~checkbox-dev/checkbox/+git/checkbox-configure:master
Diff against target: 122 lines (+25/-2)
6 files modified
checkbox-provider-template/units/test-plan-classic.pxu.in (+5/-0)
checkbox-provider-template/units/test-plan.pxu.in (+5/-0)
config/config_vars (+10/-0)
launchers_v2/wrapper_local.in (+1/-1)
launchers_v2/wrapper_local.in_classic (+1/-1)
snap/snapcraft.yaml.in_v2 (+3/-0)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Disapprove
Patrick Liu (community) Approve
StanleyHuang Needs Fixing
PeiYao Chang Pending
Vic Liu Pending
Pierre Equoy Pending
Review via email: mp+437595@code.qastaging.launchpad.net

Commit message

Add: ce-oem test plan

Add: plug for provider-ce-oem

Add: export PATH for checkbox-ce-oem
Since checkbox-ce-oem include some stage packages, add the path for the project checkbox to use those binaries.

Add: config for provider-ce-oem
Since there are some variables that are required for the jobs in provider-ce-oem. Add those configs as a reminder.

Description of the change

We created a checkbox named "checkbox-ce-oem"[1] which includes the jobs that we like to use for multiple projects. Therefore, we have to modify this template for the project checkbox to let the project checkbox able to include the case from checkbox-ce-oem.
[1] https://snapcraft.io/checkbox-ce-oem

To post a comment you must log in.
Revision history for this message
StanleyHuang (stanley31) wrote :

I think we should also include the post-suspend tests from ce-oem provider.

review: Needs Fixing
Revision history for this message
Rick Wu (rickwu4444) wrote :

@stanley,
Thanks for the review. I've updated the test plan. Many thanks.

Revision history for this message
Patrick Liu (patliu) wrote :

LGTM

review: Approve
Revision history for this message
Jonathan Cave (jocave) wrote :

Please don't do this. Having hard to track linkages between multiple snaps to satisfy project testing needs will become unmanageable.

review: Disapprove

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: