goget-ubuntu-touch

Merge lp://qastaging/~ricmm/goget-ubuntu-touch/no-legacy-subarches into lp://qastaging/goget-ubuntu-touch

  1. no-legacy-subarches
  2. Merge into trunk
Proposed by Ricardo Mendoza
Status: Needs review
Proposed branch: lp://qastaging/~ricmm/goget-ubuntu-touch/no-legacy-subarches
Merge into: lp://qastaging/goget-ubuntu-touch
Diff against target: 22 lines (+5/-0)
1 file modified
ubuntu-device-flash/snappy.go (+5/-0)
To merge this branch: bzr merge lp://qastaging/~ricmm/goget-ubuntu-touch/no-legacy-subarches
Reviewer Review Type Date Requested Status
Sergio Schvezov Needs Fixing
Michael Vogt (community) Approve
Review via email: mp+277386@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

+1

review: Approve
Reply
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

A regex might be better here in case we ever create a new arch with generic.

Also, why isn't this implemented in isLegacy?

review: Needs Fixing
Reply

Unmerged revisions

218. By Ricardo Mendoza

There are no legacy setups in non generic channels, so make sure we dont accidentally build a legacy grub config.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches