unity-mir

Merge lp://qastaging/~ricmm/unity-mir/respect-lifecycle-stages into lp://qastaging/unity-mir

  1. respect-lifecycle-stages
  2. Merge into trunk
Proposed by Ricardo Mendoza
Status: Merged
Approved by: Gerry Boland
Approved revision: 168
Merged at revision: 168
Proposed branch: lp://qastaging/~ricmm/unity-mir/respect-lifecycle-stages
Merge into: lp://qastaging/unity-mir
Diff against target: 85 lines (+21/-16)
2 files modified
src/modules/Unity/Application/application_manager.cpp (+20/-16)
src/modules/Unity/Application/application_manager.h (+1/-0)
To merge this branch: bzr merge lp://qastaging/~ricmm/unity-mir/respect-lifecycle-stages
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Gerry Boland (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+201913@code.qastaging.launchpad.net

Commit message

Correctly respect lifecycle exceptions in the new sidestage model.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:168
http://jenkins.qa.ubuntu.com/job/unity-mir-ci/226/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-amd64-ci/89
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-ci/90
        deb: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-ci/90/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-i386-ci/89

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-mir-ci/226/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

Tested on mako & manta, works fine. Code logical. Approved

review: Approve
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

+1, the code looks good as well.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches