usensord

Merge lp://qastaging/~ricmm/usensord/vibrate-no-sleep into lp://qastaging/usensord

  1. vibrate-no-sleep
  2. Merge into trunk
Proposed by Ricardo Mendoza
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 32
Merged at revision: 24
Proposed branch: lp://qastaging/~ricmm/usensord/vibrate-no-sleep
Merge into: lp://qastaging/usensord
Diff against target: 73 lines (+37/-0)
1 file modified
haptic/haptic.go (+37/-0)
To merge this branch: bzr merge lp://qastaging/~ricmm/usensord/vibrate-no-sleep
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
PS Jenkins bot continuous-integration Approve
Charles Kerr (community) Approve
Review via email: mp+256612@code.qastaging.launchpad.net

Commit message

Take a powerd state while theres an active vibration request, also give a grace period after vibration ended before suspending, so as to not peg the hardware actuator if the cpu goes offline before the end timer has expired.

To post a comment you must log in.
lp://qastaging/~ricmm/usensord/vibrate-no-sleep updated
25. By Ricardo Mendoza

Fix indentation

26. By Ricardo Mendoza

Reduce timeout to 1.5s

27. By Ricardo Mendoza

Make sure cookie is not null before attempting to clear

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:27
http://jenkins.qa.ubuntu.com/job/usensord-ci/17/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-armhf-ci/1
        deb: http://jenkins.qa.ubuntu.com/job/usensord-vivid-armhf-ci/1/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-i386-ci/1

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/usensord-ci/17/rebuild

review: Approve (continuous-integration)
lp://qastaging/~ricmm/usensord/vibrate-no-sleep updated
28. By Ricardo Mendoza

Dont stack locks

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:28
http://jenkins.qa.ubuntu.com/job/usensord-ci/18/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-armhf-ci/2
        deb: http://jenkins.qa.ubuntu.com/job/usensord-vivid-armhf-ci/2/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/usensord-ci/18/rebuild

review: Approve (continuous-integration)
lp://qastaging/~ricmm/usensord/vibrate-no-sleep updated
29. By Ricardo Mendoza

Only remove the old lock after the new one has been taken, to prevent a few ticks of lock-less processing where we could suspend

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:29
http://jenkins.qa.ubuntu.com/job/usensord-ci/19/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-armhf-ci/3
        deb: http://jenkins.qa.ubuntu.com/job/usensord-vivid-armhf-ci/3/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-i386-ci/3

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/usensord-ci/19/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

Comments inline

review: Needs Information
lp://qastaging/~ricmm/usensord/vibrate-no-sleep updated
30. By Ricardo Mendoza

Use global timer instead and keep a mutex-protected single cookie instance

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:30
http://jenkins.qa.ubuntu.com/job/usensord-ci/20/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-armhf-ci/4
        deb: http://jenkins.qa.ubuntu.com/job/usensord-vivid-armhf-ci/4/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-i386-ci/4

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/usensord-ci/20/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

Some minor comments made to ricmm in irc, but otherwise this LGTM.

review: Approve
lp://qastaging/~ricmm/usensord/vibrate-no-sleep updated
31. By Ricardo Mendoza

Move into individual vibration block

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:31
http://jenkins.qa.ubuntu.com/job/usensord-ci/21/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-amd64-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-armhf-ci/5
        deb: http://jenkins.qa.ubuntu.com/job/usensord-vivid-armhf-ci/5/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-i386-ci/5

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/usensord-ci/21/rebuild

review: Approve (continuous-integration)
lp://qastaging/~ricmm/usensord/vibrate-no-sleep updated
32. By Ricardo Mendoza

Reduce mutex scope and make sure lock also takes into consideration the sleep time

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:32
http://jenkins.qa.ubuntu.com/job/usensord-ci/22/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/usensord-vivid-armhf-ci/6/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/usensord-vivid-i386-ci/6

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/usensord-ci/22/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Looking good, working as expected.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches