Merge lp://qastaging/~ricotz/docky/pangolayout into lp://qastaging/docky
Proposed by
Rico Tzschichholz
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~ricotz/docky/pangolayout |
| Merge into: | lp://qastaging/docky |
| Diff against target: |
1371 lines (+566/-558) 9 files modified
Docky.Items/Docky.Items/AbstractDockItem.cs (+93/-91) Docky.Items/Docky.Items/IconEmblem.cs (+1/-0) Docky/Docky/Interface/DockWindow.cs (+29/-26) Docky/Docky/Menus/MenuItemWidget.cs (+45/-45) Docky/Docky/Menus/SeparatorWidget.cs (+31/-21) StandardPlugins/Clock/src/CalendarPainter.cs (+100/-98) StandardPlugins/Clock/src/ClockDockItem.cs (+119/-123) StandardPlugins/Weather/src/WeatherDocklet.cs (+33/-29) StandardPlugins/Weather/src/WeatherPainter.cs (+115/-125) |
| To merge this branch: | bzr merge lp://qastaging/~ricotz/docky/pangolayout |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Robert Dyer (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Use static Pango.Layouts to hopefully reduce memory leaks and get some more performance.
To post a comment you must log in.
Unmerged revisions
- 1662. By Rico Tzschichholz
-
fix leak
- 1661. By Rico Tzschichholz
-
merge trunk 1745
- 1660. By Rico Tzschichholz
-
still one more
- 1659. By Rico Tzschichholz
-
reset Width
- 1658. By Rico Tzschichholz
-
and more layout-stuff moved
- 1657. By Rico Tzschichholz
-
remove Width settings
- 1656. By Rico Tzschichholz
-
fix build
- 1655. By Rico Tzschichholz
-
merge trunk 1736
- 1654. By Rico Tzschichholz
-
fix leaking FontDescriptions
- 1653. By Rico Tzschichholz
-
Use static Pango.Layouts instead of creating new one everytime
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
In CalendarPainter, you dont need 3 layouts. Look where you create them, 2 are the same.