libunity

Merge lp://qastaging/~ricotz/libunity/syntax-fixes into lp://qastaging/libunity

  1. syntax-fixes
  2. Merge into trunk
Proposed by Rico Tzschichholz
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 334
Merged at revision: 334
Proposed branch: lp://qastaging/~ricotz/libunity/syntax-fixes
Merge into: lp://qastaging/libunity
Diff against target: 208 lines (+26/-25)
7 files modified
protocol/protocol-scope-interface.vala (+2/-2)
protocol/unity-scope-proxy-remote.vala (+1/-0)
src/unity-aggregator-scope-private.vala (+6/-6)
src/unity-deprecated-scope-impl.vala (+7/-7)
src/unity-scope-channel.vala (+2/-2)
src/unity-scope-dbus-impl.vala (+5/-5)
src/unity-synchronizer.vala (+3/-3)
To merge this branch: bzr merge lp://qastaging/~ricotz/libunity/syntax-fixes
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Marco Trevisan (Treviño) Pending
Review via email: mp+362923@code.qastaging.launchpad.net

Commit message

Those changes are required to build with vala 0.43.x

To post a comment you must log in.
Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

Ah I already added dh-python here https://code.launchpad.net/~khurshid-alam/libunity/remove-deprecated-scopes/+merge/362435, but it seems it was already added but did not go through trunk. https://launchpad.net/ubuntu/+source/libunity/7.1.4+18.04.20180209.1-0ubuntu2

lp://qastaging/~ricotz/libunity/syntax-fixes updated
331. By Sebastien Bacher

releasing package libunity version 7.1.4+18.04.20180209.1-0ubuntu2

332. By Sebastien Bacher

releasing package libunity version 7.1.4+18.04.20180209.1-0ubuntu3

333. By Rico Tzschichholz

Fix wrongly places out-parameters in async methods

334. By Rico Tzschichholz

WIP Fix generic type mismatches

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

This also require changes in unity-lens-application and unity-scope-home.

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

Now it is not compiling on Proposed. I get

dee-CRITICAL **: 19:20:20.959: Unable to set up DBusServer: Error binding to address: Address already in use

Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks

review: Approve
Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

Since it may require changes in dee against glib >=2.59.3, I split each diffmodel test with separate address. See https://code.launchpad.net/~khurshid-alam/libunity/glib-2.59.3/+merge/364679

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches