Merge lp://qastaging/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501 into lp://qastaging/ubuntu-calendar-app

Code wise patch seems good

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878/+edit-commit-message

Thanks for the fix! Looks good to me, I'd just suggest to add a translator comment here. (See inline comment)

And how can I add a translator comment?

@Richard, just before the i18n.tr() line, you add a comment,

// TRANSLATORS: Some random translator comment

When you build and run the app, the pot file should be updated to include the TRANSLATORS comment.

So what david wanted was something like,

// TRANSLATORS: W refers to Week, followed by the actual week number (%1)
text: i18n.tr("W%1").arg(root.weekNumber)

Thanks. I did it. Is there anything I need to do yet?

Thanks Richard, that's all that needs to be done. I.e. applying the fix, committing and pushing it. Then when everything is fine, a core app dev will approve the merge proposal, automated tests will be run against it and when they pass it will be merged to trunk.

That said, there is something that still needs to be fixed: the translator comment line uses tabs where the rest of the file uses spaces. Could you replace the tabs with spaces to be consistent with the rest of the code?

Thanks!

I have fixed it, hope everything is good now. :)

Looks good to me, thanks!