Merge lp://qastaging/~ris/unity-2d/part-fix-661049 into lp://qastaging/unity-2d/3.0

Proposed by Robert Sajdok
Status: Rejected
Rejected by: Florian Boucault
Proposed branch: lp://qastaging/~ris/unity-2d/part-fix-661049
Merge into: lp://qastaging/unity-2d/3.0
Diff against target: 13 lines (+3/-0)
1 file modified
panel/applets/appname/appnameapplet.cpp (+3/-0)
To merge this branch: bzr merge lp://qastaging/~ris/unity-2d/part-fix-661049
Reviewer Review Type Date Requested Status
Florian Boucault (community) Disapprove
Aurélien Gâteau (community) Needs Fixing
Review via email: mp+52817@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Aurélien Gâteau (agateau) wrote :

I just gave it a try and it does not work for me. It seems it only work if the application did not expose its menubar. This can happen when the panel is restarted and the application does not expose its menubar again (Qt apps have this problem for now).

review: Needs Fixing
Revision history for this message
Robert Sajdok (ris) wrote :

I tested it very precisely on maverick and it works properly. Today I tested it on natty and it does not work. I will try fix this in future.

Revision history for this message
Aurélien Gâteau (agateau) wrote :

> I tested it very precisely on maverick and it works properly. Today I tested
> it on natty and it does not work. I will try fix this in future.

Great, thanks a lot! I think the fix is probably to listen for the double-click event on the QMenuBar itself.

Revision history for this message
Michał Sawicz (saviq) wrote :

Hi there, I got this working here http://bazaar.launchpad.net/~saviq/unity-2d/unmaximize-on-drag/revision/561

Currently working on dragging, see http://bazaar.launchpad.net/~saviq/unity-2d/unmaximize-on-drag/revision/562 - I will gladly take comments :)

Revision history for this message
Florian Boucault (fboucault) wrote :
review: Disapprove

Unmerged revisions

435. By Robert Sajdok

Part of this bug: (LP: #661049)

"When a window is maximised, double clicking on the menu bar should un-maximise the window"

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches