Merge lp://qastaging/~roadmr/cdts/disable-irrelevant-tests into lp://qastaging/cdts

Proposed by Daniel Manrique
Status: Merged
Approved by: Daniel Manrique
Approved revision: 2358
Merged at revision: 2358
Proposed branch: lp://qastaging/~roadmr/cdts/disable-irrelevant-tests
Merge into: lp://qastaging/cdts
Diff against target: 77 lines (+0/-67)
1 file modified
test-in-vagrant.sh (+0/-67)
To merge this branch: bzr merge lp://qastaging/~roadmr/cdts/disable-irrelevant-tests
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+208463@code.qastaging.launchpad.net

Commit message

test-in-vagrant.sh: Removed vagrant testing of outdated components.

We're no longer keeping the "copy" of lp:checkbox up to date, so as a short-term
solution for test breakage when running tests on python 3.4, removing these tests seems
a good compromise. These components are built and tested from lp:checkbox.

Description of the change

test-in-vagrant.sh: Removed vagrant testing of outdated components.

We're no longer keeping the "copy" of lp:checkbox up to date, so as a short-term
solution for test breakage when running tests on python 3.4, removing these tests seems
a good compromise. These components are built and tested from lp:checkbox.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Self-approving to unblock other merges. Let me know if this solution is not good, then we can revert the merge and find a better one, but for the time being it's blocking other merges for no good reason.

review: Approve
Revision history for this message
Zygmunt Krynicki (zyga) wrote :
Download full text (5.3 KiB)

+1 from me, sorry for being asleep
26 lut 2014 21:08 "Daniel Manrique" <email address hidden>
napisał(a):

> Daniel Manrique has proposed merging
> lp:~roadmr/checkbox-ihv-ng/disable-irrelevant-tests into lp:checkbox-ihv-ng.
>
> Commit message:
> test-in-vagrant.sh: Removed vagrant testing of outdated components.
>
> We're no longer keeping the "copy" of lp:checkbox up to date, so as a
> short-term
> solution for test breakage when running tests on python 3.4, removing
> these tests seems
> a good compromise. These components are built and tested from lp:checkbox.
>
> Requested reviews:
> Checkbox IHV NG (checkbox-ihv-ng)
>
> For more details, see:
>
> https://code.launchpad.net/~roadmr/checkbox-ihv-ng/disable-irrelevant-tests/+merge/208463
>
> test-in-vagrant.sh: Removed vagrant testing of outdated components.
>
> We're no longer keeping the "copy" of lp:checkbox up to date, so as a
> short-term
> solution for test breakage when running tests on python 3.4, removing
> these tests seems
> a good compromise. These components are built and tested from lp:checkbox.
> --
>
> https://code.launchpad.net/~roadmr/checkbox-ihv-ng/disable-irrelevant-tests/+merge/208463
> You are subscribed to branch lp:checkbox-ihv-ng.
>
> === modified file 'test-in-vagrant.sh'
> --- test-in-vagrant.sh 2014-02-16 19:18:28 +0000
> +++ test-in-vagrant.sh 2014-02-26 20:07:56 +0000
> @@ -61,73 +61,6 @@
> fi
> cat $TIMING | sed -e "s/^/[$target] (timing) /"
>
> - # Run checkbox unit tests
> - if time -o $TIMING vagrant ssh $target -c 'cd src/checkbox-old &&
> python3 setup.py test' >vagrant-logs/$target.checkbox.log
> 2>vagrant-logs/$target.checkbox.err; then
> - echo "[$target] CheckBox test suite: $PASS"
> - else
> - outcome=1
> - echo "[$target] CheckBox test suite: $FAIL"
> - echo "[$target] stdout: $(pastebinit
> vagrant-logs/$target.checkbox.log)"
> - echo "[$target] stderr: $(pastebinit
> vagrant-logs/$target.checkbox.err)"
> - fi
> - cat $TIMING | sed -e "s/^/[$target] (timing) /"
> -
> - # Refresh plainbox installation. This is needed if .egg-info (which is
> - # essential for 'develop' to work) was removed in the meantime, for
> - # example, by tarmac.
> - if ! time -o $TIMING vagrant ssh $target -c 'cd src/plainbox &&
> python3 setup.py egg_info' >vagrant-logs/$target.egginfo.log
> 2>vagrant-logs/$target.egginfo.err; then
> - outcome=1
> - echo "[$target] Running 'plainbox/setup.py egg_info' failed"
> - echo "[$target] stdout: $(pastebinit
> vagrant-logs/$target.egginfo.log)"
> - echo "[$target] stderr: $(pastebinit
> vagrant-logs/$target.egginfo.err)"
> - echo "[$target] NOTE: unable to execute tests, marked as failed"
> - fi
> - cat $TIMING | sed -e "s/^/[$target] (timing) /"
> -
> - # Run plainbox unit tests
> - # TODO: It would be nice to support fast failing here
> - if time -o $TIMING vagrant ssh $target -c 'cd src/plainbox && python3
> setup.py test' >vagrant-logs/$target.plainbox.log
> 2>vagrant-logs/$target.plainbox.err; then
> - echo "[$target] PlainBox test suite: $PASS"
> - else
> - outcome=1
> - ...

Read more...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches