Merge lp://qastaging/~roadmr/cdts/exporter-client-name-option into lp://qastaging/cdts

Proposed by Daniel Manrique
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2368
Merged at revision: 2368
Proposed branch: lp://qastaging/~roadmr/cdts/exporter-client-name-option
Merge into: lp://qastaging/cdts
Diff against target: 103 lines (+18/-13)
4 files modified
plainbox-gui/canonical-driver-test-suite/main.cpp (+1/-0)
plainbox-gui/canonical-driver-test-suite/qml/SubmissionDialog.qml (+7/-5)
plainbox-gui/gui-engine/gui-engine.cpp (+6/-6)
plainbox-gui/gui-engine/gui-engine.h (+4/-2)
To merge this branch: bzr merge lp://qastaging/~roadmr/cdts/exporter-client-name-option
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+213750@code.qastaging.launchpad.net

Commit message

  canonical-driver-test-suite: Support sending the client-name as an exporter option.

  This enables exporters to show information about the client that produced the test run.

  Currently this is used in the XML (and by extension, the HTML) exporters.

Description of the change

  canonical-driver-test-suite: Support sending the client-name as an exporter option.

  This enables exporters to show information about the client that produced the test run.

  Currently this is used in the XML (and by extension, the HTML) exporters.

This is based on code already present in checkbox-gui, it also needs plainbox 0.6~dev+bzr2864 or higher for the non-boolean option-list support.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches