Canonical Driver Test Suite

Merge lp://qastaging/~roadmr/cdts/ihv-firmware-rearranging into lp://qastaging/cdts

ihv-firmware-rearranging
Merge into trunk

Proposed by Daniel Manrique on 2014-08-12

Status:	Merged
Approved by:	Daniel Manrique on 2014-08-15
Approved revision:	33
Merged at revision:	32
Proposed branch:	lp://qastaging/~roadmr/cdts/ihv-firmware-rearranging
Merge into:	lp://qastaging/cdts
Diff against target:	216 lines (+150/-39) 2 files modified plainbox-provider-canonical-driver-test-suite/whitelists/ihv-firmware-advanced.whitelist (+76/-25) plainbox-provider-canonical-driver-test-suite/whitelists/ihv-firmware.whitelist (+74/-14)
To merge this branch:	bzr merge lp://qastaging/~roadmr/cdts/ihv-firmware-rearranging
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Chris Gregan (community)		2014-08-12	Approve on 2014-08-15
Review via email: mp+230549@code.qastaging.launchpad.net

Commit message

Split known fwts tests into firmware and fwts-advanced whitelists; renamed fwts-advanced to firmware-advanced

Description of the change

Split known fwtst tests into firmware and fwts-advanced whitelists; renamed fwts-advanced to firmware-advanced

Revision history for this message

Chris Gregan (cgregan) wrote on 2014-08-13:

Looks like the names of the whitelists is reversed according to the tests in the lists. Also it seems we are missing a few of the dump cases.

review: Needs Fixing

lp://qastaging/~roadmr/cdts/ihv-firmware-rearranging updated on 2014-08-13

32. By Daniel Manrique on 2014-08-13: Split known fwts tests into firmware and fwts-advanced whitelists; renamed fwts-advanced to firmware-advanced

Revision history for this message

Daniel Manrique (roadmr) wrote on 2014-08-13:

I reversed the whitelists.

Note that our wrapper doesn't have *all* fwts tests declared. The only dump test it knows about is acpidump. fwts proper has more dump tests, see the complete list here:

http://paste.ubuntu.com/8037805/

Let me know which ones should be added. This will need adding them to the whitelist, but also to add them to the wrapper script, which has to be done in lp:checkbox.

Revision history for this message

Chris Gregan (cgregan) wrote on 2014-08-13:

The Advanced whitelist should have these tests:
https://docs.google.com/a/canonical.com/spreadsheets/d/10AWC0GRAE-F7uFs8euid72p4O8tJ2RF3Ec5GdXUvgls/edit#gid=0

On Wed, Aug 13, 2014 at 1:17 PM, Daniel Manrique <
<email address hidden>> wrote:

> I reversed the whitelists.
>
> Note that our wrapper doesn't have *all* fwts tests declared. The only
> dump test it knows about is acpidump. fwts proper has more dump tests, see
> the complete list here:
>
> http://paste.ubuntu.com/8037805/
>
> Let me know which ones should be added. This will need adding them to the
> whitelist, but also to add them to the wrapper script, which has to be done
> in lp:checkbox.
> --
>
> https://code.launchpad.net/~roadmr/cdts/ihv-firmware-rearranging/+merge/230549
> You are reviewing the proposed merge of
> lp:~roadmr/cdts/ihv-firmware-rearranging into lp:cdts.
>

--
Chris Gregan
Project Manager
Professional and Engineering Services
Canonical USA Inc.
<email address hidden>
cgregan[irc.freenode.net]
W-781-761-9448

----
1024/8806032D
E70F 7391 6C78 9B9E 6461 1CC7 B168 E1E7 8806 032D

lp://qastaging/~roadmr/cdts/ihv-firmware-rearranging updated on 2014-08-14