Merge lp://qastaging/~roadmr/checkbox/855328 into lp://qastaging/checkbox
Proposed by
Daniel Manrique
| Status: | Merged |
|---|---|
| Merged at revision: | 1073 |
| Proposed branch: | lp://qastaging/~roadmr/checkbox/855328 |
| Merge into: | lp://qastaging/checkbox |
| Diff against target: |
57 lines (+14/-8) 2 files modified
debian/changelog (+2/-1) plugins/intro_prompt.py (+12/-7) |
| To merge this branch: | bzr merge lp://qastaging/~roadmr/checkbox/855328 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brendan Donegan (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
As per the associated bug, this adds a string warning the user about data loss, and advising to save all work and close all running applications.
I did it in a way that doesn't change the existing "welcome" message, but concatenates a new string on it. This way, we're not actually "changing" an existing string, but "adding" a new one, which could make it easier for translators to manage the change.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I was only going to comment that some formatting on the warning message to bring the users attention to it might be good, but since the field doesn't parse HTML and it wouldn't really be prudent at this point to go messing around with the UI (plus the fact that the message is noticeable enough anyway), I approve and have merged this.