Merge lp://qastaging/~roadmr/checkbox/c-c-s-resources into lp://qastaging/checkbox

Proposed by Daniel Manrique
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2763
Merged at revision: 2766
Proposed branch: lp://qastaging/~roadmr/checkbox/c-c-s-resources
Merge into: lp://qastaging/checkbox
Diff against target: 28 lines (+7/-2)
1 file modified
checkbox-ng/checkbox_ng/commands/test_cli.py (+7/-2)
To merge this branch: bzr merge lp://qastaging/~roadmr/checkbox/c-c-s-resources
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+209744@code.qastaging.launchpad.net

Commit message

    checkbox_ng:commands:test_cli: test correct tracking of resources.

    This ensures that the CLI's tree selection visually "ignores" resources
    while still keeping track of them internally and returning them as part
    of the selection when queried. It's a retrofitted test for the earlier
    fix to bug LP: #1288399.

Description of the change

    checkbox_ng:commands:test_cli: test correct tracking of resources.

    This ensures that the CLI's tree selection visually "ignores" resources
    while still keeping track of them internally and returning them as part
    of the selection when queried. It's a retrofitted test for the earlier
    fix to bug LP: #1288399.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looking...

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I don't mind this at all but looking at the code this adds fixes to makes me realize that it is just broken.

The place where we added the logic to implicitly select all resource jobs is wrong. The SelectableTreeNode should not know anything about that. It just adds to the set of things that are wrong about that code.

Anyway, the tests are okay, though this is all bonkers

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches