Checkbox

Merge lp://qastaging/~roadmr/checkbox/checkbox-packaging-1260535-deps into lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging

  1. checkbox-packaging-1260535-deps
  2. Merge into checkbox-packaging
Proposed by Daniel Manrique
Status: Merged
Approved by: Jeff Lane 
Approved revision: 46
Merged at revision: 47
Proposed branch: lp://qastaging/~roadmr/checkbox/checkbox-packaging-1260535-deps
Merge into: lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging
Diff against target: 23 lines (+3/-0)
1 file modified
debian/control (+3/-0)
To merge this branch: bzr merge lp://qastaging/~roadmr/checkbox/checkbox-packaging-1260535-deps
Reviewer Review Type Date Requested Status
Jeff Lane  Approve
Review via email: mp+198981@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2013-12-13.

Commit message

Adds the missing dependencies to plainbox-provider-certification-server package. These dependencies are suggests (not recommends) of plainbox-provider-checkbox, so they weren't getting installed on server.

Description of the change

Adds the missing dependencies to plainbox-provider-certification-server package. These dependencies are suggests (not recommends) of plainbox-provider-checkbox, so they weren't getting installed on server.

targeted against the right branch now :)

To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote : Posted in a previous version of this proposal

Hey Daniel, thanks for jumping on this so quickly. But why does a fix that just adds a few packaging dependencies generate a 9200+ line diff w/ 77 files? something seems to be amiss...

review: Needs Fixing
Revision history for this message
Daniel Manrique (roadmr) wrote : Posted in a previous version of this proposal

Oh, that's because I'm dumb and proposed the merge against the wrong branch... I'll fix it.

Revision history for this message
Jeff Lane  (bladernr) wrote : Posted in a previous version of this proposal

OH... Yeah, that'll do it. To be honest, I would have done the same
thing, probably.

On Fri, Dec 13, 2013 at 12:43 PM, Daniel Manrique
<email address hidden> wrote:
> Oh, that's because I'm dumb and proposed the merge against the wrong branch... I'll fix it.
> --
> https://code.launchpad.net/~roadmr/checkbox/checkbox-packaging-1260535-deps/+merge/198949
> You are reviewing the proposed merge of lp:~roadmr/checkbox/checkbox-packaging-1260535-deps into lp:checkbox.

--
Jeff Lane - Server and Cloud Certification and Tools Development
Ubuntu Ham: W4KDH
Freenode IRC: bladernr or bladernr_
gpg: 1024D/3A14B2DD 8C88 B076 0DD7 B404 1417 C466 4ABD 3635 3A14 B2DD

Revision history for this message
Jeff Lane  (bladernr) wrote :

Awesome. Thanks Daniel!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches