Merge lp://qastaging/~roadmr/checkbox/fix-validation-exception into lp://qastaging/checkbox
Proposed by
Daniel Manrique
| Status: | Merged |
|---|---|
| Merged at revision: | 1646 |
| Proposed branch: | lp://qastaging/~roadmr/checkbox/fix-validation-exception |
| Merge into: | lp://qastaging/checkbox |
| Diff against target: |
43 lines (+12/-4) 2 files modified
checkbox_qt/qt_interface.py (+7/-2) debian/changelog (+5/-2) |
| To merge this branch: | bzr merge lp://qastaging/~roadmr/checkbox/fix-validation-exception |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zygmunt Krynicki (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
A quick fix for the linked bug, ensuring that strings passed to showError in the QT frontend are indeed always strings. For this I used a simple conditional as well as forcing str() on everything passed to the showError method. Review appreciated in case I missed anything with string/data encoding.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good +1
As a personal preference (I don't know if we have a style guide for that) I prefer to use 'is' to check for being None. This way you at least prevent the calling of __eq__ on the object and since there is only one None it somewhat makes sense semantically too.
I'll gladly merge this though