Merge lp://qastaging/~roadmr/checkbox/packaging-ubuntu-sdk-build-depends-fix into lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging

Proposed by Daniel Manrique
Status: Merged
Approved by: Daniel Manrique
Approved revision: 48
Merged at revision: 48
Proposed branch: lp://qastaging/~roadmr/checkbox/packaging-ubuntu-sdk-build-depends-fix
Merge into: lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging
Diff against target: 47 lines (+25/-2)
1 file modified
debian/control (+25/-2)
To merge this branch: bzr merge lp://qastaging/~roadmr/checkbox/packaging-ubuntu-sdk-build-depends-fix
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Needs Information
Daniel Manrique (community) Approve
Review via email: mp+199047@code.qastaging.launchpad.net

Commit message

This implements Brendan's idea about removing ubuntu-sdk as a build-depends, and instead spelling out the packages it pulls. In the process I removed some unneeded packages such as qmlscene, documentation, examples, qtcreator and qtcreator plugins (since it's just for command-line building, those tools aren't needed).

Description of the change

This implements Brendan's idea about removing ubuntu-sdk as a build-depends, and instead spelling out the packages it pulls. In the process I removed some unneeded packages such as qmlscene, documentation, examples, qtcreator and qtcreator plugins (since it's just for command-line building, those tools aren't needed).

I tested it in a local sbuild using precise and saucy (to test the LTS and latest stable release), and it was able to build packages correctly.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

I'll self-approve this based on my local testing results, to see if I can unblock builds (hey, it's not building anyway so I can't really break it more). Still, please review for sanity.

review: Approve
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good, I'd +1 it as well. I have a few questions though:

+ cordova-ubuntu-2.8,
+ cordova-ubuntu-2.8-dev,

Why do we build depend on that? We're certainly *not* using cordova.

+Build-Depends: click,
+ click-dev,

As above

43 + ubuntu-html5-theme,

As above

review: Needs Information
Revision history for this message
Daniel Manrique (roadmr) wrote :

Hi! Removed the above as well as ubuntu-ui-toolkit-theme, and the build still succeeds so I'll propose a merge with those changes. Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches