Merge lp://qastaging/~roadmr/hwcert-tools/reporting-tools-rts-nag into lp://qastaging/~hardware-certification/hwcert-tools/reporting-tools

Proposed by Daniel Manrique
Status: Merged
Approved by: Brendan Donegan
Approved revision: 140
Merged at revision: 136
Proposed branch: lp://qastaging/~roadmr/hwcert-tools/reporting-tools-rts-nag
Merge into: lp://qastaging/~hardware-certification/hwcert-tools/reporting-tools
Diff against target: 193 lines (+76/-18)
1 file modified
certification_reports/certificate_check.py (+76/-18)
To merge this branch: bzr merge lp://qastaging/~roadmr/hwcert-tools/reporting-tools-rts-nag
Reviewer Review Type Date Requested Status
Brendan Donegan (community) Approve
Daniel Manrique (community) Needs Resubmitting
Review via email: mp+202536@code.qastaging.launchpad.net

Commit message

Adds an "rts" report to certificate_check.py. This will look at "scheduled" certificates and, if they contain a note titled "RTS" containing nothing but a parsable YYYY-MM-DD date, and this date is past, it will indicate the certificate is ready to be finalized.

Description of the change

Adds an "rts" report to certificate_check.py. This will look at "scheduled" certificates and, if they contain a note titled "RTS" containing nothing but a parsable YYYY-MM-DD date, and this date is past, it will indicate the certificate is ready to be finalized.

To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Me and ara discussed this and the only thing that changed was that the process assumes that Scheduled certificates will be set to Pass, since certificates that fail can just be set to Fail immediately. So just change the text of the message to say to set the cert to Pass.

review: Needs Fixing
140. By Daniel Manrique

Updated message to ask for PASS of all scheduled RTSed certificates

Revision history for this message
Daniel Manrique (roadmr) wrote :

Done! thanks!

review: Needs Resubmitting
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Ok - that gets the point across

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches