Ubuntu
checkbox package

Merge lp://qastaging/~roadmr/ubuntu/quantal/checkbox/0.14.9 into lp://qastaging/ubuntu/quantal/checkbox

  1. Quantal (12.10)
  2. 0.14.9
  3. Merge into quantal
Proposed by Daniel Manrique
Status: Merged
Merge reported by: Luke Yelavich
Merged at revision: not available
Proposed branch: lp://qastaging/~roadmr/ubuntu/quantal/checkbox/0.14.9
Merge into: lp://qastaging/ubuntu/quantal/checkbox
Diff against target: 2871 lines (+2175/-238)
14 files modified
checkbox/dbus/__init__.py (+89/-0)
checkbox/dbus/udisks2.py (+479/-0)
checkbox/heuristics/__init__.py (+56/-0)
checkbox/heuristics/udev.py (+44/-0)
checkbox/heuristics/udisks2.py (+62/-0)
checkbox/parsers/udevadm.py (+19/-0)
checkbox/tests/heuristics.py (+40/-0)
checkbox/udev.py (+93/-0)
debian/changelog (+15/-0)
debian/control (+1/-0)
jobs/mediacard.txt.in (+24/-24)
scripts/removable_storage_test (+425/-175)
scripts/removable_storage_watcher (+823/-37)
setup.py (+5/-2)
To merge this branch: bzr merge lp://qastaging/~roadmr/ubuntu/quantal/checkbox/0.14.9
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Ubuntu branches Pending
Review via email: mp+128777@code.qastaging.launchpad.net

Description of the change

This adds udisks2 support to removable storage tests in checkbox. This encompasses media cards (all variants), USB storage devices, ESATA and FireWire.

The code required to implement this is somewhat extensive, but is necessary because udisks1 is not shipping in Quantal and without this, none of the checkbox removable storage tests will work.

I was told we shouldn't need to request an explicit FFe for this as it needs release team review anyway, but the spirit of this is a "new feature", please take this into account when reviewing it.

I'll add the required build and install logs to the linked bug anyway, in case they're needed for the review.

Thanks and apologies for the late-landing request.

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Seems fine to me, I'll merge once the bug https://bugs.launchpad.net/checkbox/+bug/1016035 gets approved by the release team.

review: Approve
Revision history for this message
Ara Pulido (ara) wrote :

The release team is asking to upload this, so they can review it in the queue

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches