Unity Control Center

Merge lp://qastaging/~robert-ancell/unity-control-center/even-icon-sizes into lp://qastaging/unity-control-center

even-icon-sizes
Merge into trunk

Proposed by Robert Ancell on 2014-03-17

Status:

Merged

Approved by:

Sebastien Bacher on 2014-03-17

Approved revision:

12753

Merged at revision:

12755

Proposed branch:

lp://qastaging/~robert-ancell/unity-control-center/even-icon-sizes

Merge into:

lp://qastaging/unity-control-center

Diff against target:

136 lines (+25/-28)

1 file modified

panels/appearance/cc-appearance-panel.c (+25/-28)

To merge this branch:

bzr merge lp://qastaging/~robert-ancell/unity-control-center/even-icon-sizes

Low

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Sebastien Bacher		2014-03-17	Approve on 2014-03-17
PS Jenkins bot (community)	continuous-integration		Approve on 2014-03-17
Review via email: mp+211238@code.qastaging.launchpad.net

Commit message

Only allow icons sizes to be even numbers because odd sizes look blurry.

Description of the change

Limit the icon sizes to even numbers by using a scale for the half-size and then doubling it.

This obsoletes the proposal in lp:~kokoto-java/unity-control-center/fix-lp-1292112.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-17:

FAILED: Continuous integration, rev:12752
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~robert-ancell/unity-control-center/even-icon-sizes/+merge/211238/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-control-center-ci/72/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-amd64-ci/72
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-armhf-ci/72
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-i386-ci/73

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-control-center-ci/72/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

asmoore82 (asmoore82) wrote on 2014-03-17:

This works great! But the new effective page increment might be unintentionally large. Since it's 8 with a "scaling factor" of 2x it actually jumps 16 at a time. I would recommend 4 now to get the effect of 8:

+++ panels/appearance/cc-appearance-panel.c 2014-03-17 03:50:51 +0000
@@ -1869,1 +1869,1 @@
- iconsize_adj = gtk_adjustment_new (DEFAULT_ICONSIZE / 2, MIN_ICONSIZE / 2, MAX_ICONSIZE / 2, 1, 8, 0);
+ iconsize_adj = gtk_adjustment_new (DEFAULT_ICONSIZE / 2, MIN_ICONSIZE / 2, MAX_ICONSIZE / 2, 1, 4, 0);

Thanks!

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-17:

PASSED: Continuous integration, rev:12752
http://jenkins.qa.ubuntu.com/job/unity-control-center-ci/73/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-amd64-ci/73
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-armhf-ci/73
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-i386-ci/74

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-control-center-ci/73/rebuild

review: Approve (continuous-integration)

lp://qastaging/~robert-ancell/unity-control-center/even-icon-sizes updated on 2014-03-17

12753. By Robert Ancell on 2014-03-17: Fix icon size adjustment page size being out by a factor of two

Revision history for this message

Robert Ancell (robert-ancell) wrote on 2014-03-17:

> This works great! But the new effective page increment might be
> unintentionally large. Since it's 8 with a "scaling factor" of 2x it actually
> jumps 16 at a time. I would recommend 4 now to get the effect of 8:

Thanks for spotting that, fixed.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-17:

PASSED: Continuous integration, rev:12753
http://jenkins.qa.ubuntu.com/job/unity-control-center-ci/74/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-amd64-ci/74
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-armhf-ci/74
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-i386-ci/75