Merge lp://qastaging/~robert-ancell/unity-greeter/lp-1121660 into lp://qastaging/unity-greeter

Proposed by Robert Ancell
Status: Needs review
Proposed branch: lp://qastaging/~robert-ancell/unity-greeter/lp-1121660
Merge into: lp://qastaging/unity-greeter
Diff against target: 201 lines (+88/-9)
5 files modified
src/prompt-box.vala (+3/-1)
src/unity-greeter.vala (+16/-1)
src/user-list.vala (+58/-6)
tests/test.vala (+1/-1)
tests/unity-greeter.vala (+10/-0)
To merge this branch: bzr merge lp://qastaging/~robert-ancell/unity-greeter/lp-1121660
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michael Terry Pending
Unity Greeter Development Team Pending
Review via email: mp+147595@code.qastaging.launchpad.net

Commit message

Add visual indication of automatic login and abort when selected user changes

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

As discussed IRL, I'd prefer the countdown text to not be on the button itself.

Maybe a fake PAM info line with the phrase "You will be logged in after %d seconds"? (assuming it fits)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:759
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~robert-ancell/unity-greeter/lp-1121660/+merge/147595/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-greeter-ci/4/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-greeter-ci/./label=precise/4/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/unity-greeter-ci/4//rebuild/?

review: Needs Fixing (continuous-integration)

Unmerged revisions

759. By Robert Ancell

Add visual indication of automatic login and abort when selected user changes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches