Merge lp://qastaging/~robertcarr/libindicate/custom-icon-theme into lp://qastaging/libindicate/0.6
Proposed by
Robert Carr
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://qastaging/~robertcarr/libindicate/custom-icon-theme |
| Merge into: | lp://qastaging/libindicate/0.6 |
| Diff against target: |
299 lines (+181/-1) 8 files modified
libindicate/indicate-interface.xml (+1/-0) libindicate/listener.c (+6/-0) libindicate/listener.h (+4/-0) libindicate/server.c (+49/-1) libindicate/server.h (+2/-0) tests/Makefile.am (+32/-0) tests/test-icon-theme-client.c (+35/-0) tests/test-icon-theme-server.c (+52/-0) |
| To merge this branch: | bzr merge lp://qastaging/~robertcarr/libindicate/custom-icon-theme |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ted Gould | Pending | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2012-02-09.
Description of the change
This adds support for an icon theme property to IndicateServer.
Ted I believe we discussed the reasoning behind this? Essesntially Unity Webapps only wants to write out one desktop file for GMail, but wants the messaging indicator to use the favicon (while of course we wont use this in the launcher), so we need the messaging indicator to be able to load an icon theme in the users home directory.
Thanks!
To post a comment you must log in.
Revision history for this message
| Robert Carr (robertcarr) wrote | # |
Unmerged revisions
- 442. By Robert Carr
-
Add test for icon theme properties
- 441. By Robert Carr
-
server: Server side implementation of icontheme property
- 440. By Robert Carr
-
listener: Add getter for icon theme property
- 439. By Robert Carr
-
Add icontheme property to indicate interface
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This is used in:
https:/