libunity

Merge lp://qastaging/~robertcarr/libunity/desktopfile-paths into lp://qastaging/libunity

desktopfile-paths
Merge into trunk

Proposed by Robert Carr on 2011-09-08

Status:	Merged
Merged at revision:	77
Proposed branch:	lp://qastaging/~robertcarr/libunity/desktopfile-paths
Merge into:	lp://qastaging/libunity
Diff against target:	138 lines (+46/-3) 4 files modified configure.ac (+1/-0) src/unity-appinfo-manager.vala (+34/-1) test/vala/test-appinfo-manager.vala.in (+9/-0) test/vala/test-vala.vala (+2/-2)
To merge this branch:	bzr merge lp://qastaging/~robertcarr/libunity/desktopfile-paths
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Mikkel Kamstrup Erlandsen (community)		2011-09-08	Approve on 2011-09-09
Review via email: mp+74612@code.qastaging.launchpad.net

Description of the change

Implement a get_path method similar to the get_categories work around.

lp://qastaging/~robertcarr/libunity/desktopfile-paths updated on 2011-09-08

72. By Robert Carr on 2011-09-08: Whoops actually make and clear the hash table
73. By Robert Carr on 2011-09-08: Fix indentation
74. By Robert Carr on 2011-09-08: Unit test for get_paths
75. By Robert Carr on 2011-09-08: We need to resolve relative paths for desktop files to absolute paths before storying them in the hash

Revision history for this message

Mikkel Kamstrup Erlandsen (kamstrup) wrote on 2011-09-09:

Awesome Robert, thanks.

I merged this with a slight tweak - in the tests there is no need for a .vala.in. We have a magical config.vapi that resolves to defines set on the gcc commandline in test/vala/Makefile.am. So we can use Config.TESTDIR in out test Vala code to resolve the absolute test path.

review: Approve