Merge lp://qastaging/~robertcarr/nux/check-dndfuncs into lp://qastaging/nux
Proposed by
Robert Carr
| Status: | Merged |
|---|---|
| Approved by: | Gord Allott |
| Approved revision: | 486 |
| Merged at revision: | 486 |
| Proposed branch: | lp://qastaging/~robertcarr/nux/check-dndfuncs |
| Merge into: | lp://qastaging/nux |
| Diff against target: |
14 lines (+4/-0) 1 file modified
NuxGraphics/GraphicsDisplayX11.cpp (+4/-0) |
| To merge this branch: | bzr merge lp://qastaging/~robertcarr/nux/check-dndfuncs |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity Team | Pending | ||
|
Review via email:
|
|||
Description of the change
Make sure we haven't zeroed our DND source funcs before calling get_data_for_type.
Note the attached bug for something that triggers this.
It's a little mysterious as to how this happens. As EndDndDrag is never called before this crash...so it's quite difficult to imagine how the entire _dnd_source_funcs struct gets zeroed...
This is probably worth looking in to later, but so close to release it seemed like just avoiding the crash (and fixing DND in to totem) was the way to go.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
