Ubuntu Accomplishments Viewer

Merge lp://qastaging/~robin-gloster/ubuntu-accomplishments-viewer/pep8 into lp://qastaging/ubuntu-accomplishments-viewer

  1. pep8
  2. Merge into accomplishments-viewer
Proposed by Robin Gloster
Status: Merged
Merged at revision: 223
Proposed branch: lp://qastaging/~robin-gloster/ubuntu-accomplishments-viewer/pep8
Merge into: lp://qastaging/ubuntu-accomplishments-viewer
Diff against target: 2812 lines (+637/-620)
16 files modified
Changelog (+3/-1)
accomplishments_viewer/AboutAccomplishmentsViewerDialog.py (+18/-16)
accomplishments_viewer/AccomplishmentsViewerWindow.py (+365/-354)
accomplishments_viewer/EditExtrainfoDialog.py (+74/-79)
accomplishments_viewer/PreferencesAccomplishmentsViewerDialog.py (+23/-26)
accomplishments_viewer/__init__.py (+18/-15)
accomplishments_viewer_lib/AboutDialog.py (+13/-13)
accomplishments_viewer_lib/Builder.py (+20/-21)
accomplishments_viewer_lib/PreferencesDialog.py (+13/-13)
accomplishments_viewer_lib/Window.py (+20/-19)
accomplishments_viewer_lib/__init__.py (+8/-9)
accomplishments_viewer_lib/accomplishments_viewerconfig.py (+9/-10)
accomplishments_viewer_lib/helpers.py (+18/-12)
bin/accomplishments-viewer (+11/-11)
tests/test_example.py (+13/-10)
tests/test_lint.py (+11/-11)
To merge this branch: bzr merge lp://qastaging/~robin-gloster/ubuntu-accomplishments-viewer/pep8
Reviewer Review Type Date Requested Status
Rafał Cieślak Approve
Matt Fischer Approve
Review via email: mp+136211@code.qastaging.launchpad.net

Description of the change

Fixed most pep8 issues

To post a comment you must log in.
Revision history for this message
Matt Fischer (mfisch) wrote :

Here's a diff with all whitespace changes removed:

http://paste.ubuntu.com/1390196/

Revision history for this message
Matt Fischer (mfisch) wrote :

Looks fine to me, but Cielak should also look, also what testing did you do?

review: Approve
Revision history for this message
Robin Gloster (robin-gloster) wrote :

Visited all pages and changed everything in the viewer i could find and
think of.
From what I could tell it should work exactly as before except for the k ->
kid fix which should have killed the viewer before.

2012/11/26 Matt Fischer <email address hidden>

> Review: Approve
>
> Looks fine to me, but Cielak should also look, also what testing did you
> do?
> --
>
> https://code.launchpad.net/~robin-gloster/ubuntu-accomplishments-viewer/pep8/+merge/136211
> You are the owner of lp:~robin-gloster/ubuntu-accomplishments-viewer/pep8.
>

Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

I have carefully reviewed these changes, and they seem perfectly fine. I have also did a bunch of tests for the viewer, and as expected - nothing suspicious could be detected. Thanks Robin for these fixes!

review: Approve
lp://qastaging/~robin-gloster/ubuntu-accomplishments-viewer/pep8 updated
221. By Rafał Cieślak

Merging in the branch that introduces use of GtkInfoBars for notifications

222. By Rafał Cieślak

Fixed #1084058.

Revision history for this message
Matt Fischer (mfisch) wrote :

Rafal,

Are you going to merge this?

lp://qastaging/~robin-gloster/ubuntu-accomplishments-viewer/pep8 updated
223. By Rafał Cieślak

Merged in Robin's PEP fixes

Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

Just merged it in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: