AngryBirds WebApp

Merge lp://qastaging/~robru/unity-webapps-angrybirds/require-utils into lp://qastaging/unity-webapps-angrybirds

  1. require-utils
  2. Merge into trunk
Proposed by Robert Bruce Park
Status: Merged
Merged at revision: 27
Proposed branch: lp://qastaging/~robru/unity-webapps-angrybirds/require-utils
Merge into: lp://qastaging/unity-webapps-angrybirds
Diff against target: 10 lines (+1/-0)
1 file modified
AngryBirds.user.js (+1/-0)
To merge this branch: bzr merge lp://qastaging/~robru/unity-webapps-angrybirds/require-utils
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Francis Ginther Pending
Didier Roche-Tolomelli Pending
Alexandre Abreu Pending
Review via email: mp+163229@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2013-05-09.

Commit message

Require utils.js in order to pacify style_checker.js

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:27
http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-ci/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-raring-amd64-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-raring-armhf-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-angrybirds-ci/1/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote : Posted in a previous version of this proposal

Can somebody tell jenkins to pull the build dep from the PPA?

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote : Posted in a previous version of this proposal

I think you need to check with vrruiz, they should include the dest ppa, which is next.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:27
http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-ci/2/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-raring-amd64-ci/2/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-raring-armhf-ci/2/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-angrybirds-ci/2/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:27
http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-ci/3/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-raring-amd64-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-raring-armhf-ci/3/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-angrybirds-ci/3/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote : Posted in a previous version of this proposal

Robert: ppa:webapps/staging has been added as jenkins hook. Please, resubmit.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:27
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~robru/unity-webapps-angrybirds/require-utils/+merge/163030/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-ci/4/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-raring-amd64-ci/4/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-raring-armhf-ci/4/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-angrybirds-ci/4/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote : Posted in a previous version of this proposal

Mmmh why would you need the require when you don't really use any of it? ... I am not sure jslint supports const (which is not EcmaScript5), ...

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote : Posted in a previous version of this proposal

Mmmh why would you need the require when you don't really use any of it? ... I am not sure jslint supports const (which is not EcmaScript5), ...

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:27
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~robru/unity-webapps-angrybirds/require-utils/+merge/163169/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-ci/5/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-raring-amd64-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-raring-armhf-ci/5/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-angrybirds-ci/5/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:27
http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-ci/6/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-raring-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-angrybirds-raring-armhf-ci/6

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-angrybirds-ci/6/rebuild

review: Approve (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

Alex, I agree that an unused import is not a great solution, but can you think of anything better? jslint is clearly messed up, because it's complaining about const here but not in any of the packages that require utils.js. Something about the require makes jslint stop complaining... So this MP is just my way of saying "hey jslint, shut up already" ;-)

I guess better solution is to make jslint not hate const, or use something other than const (though if you change const, you have to make the same change in all 41 webapps...).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: