Merge lp://qastaging/~rockstar/tarmac/die-makefile-die into lp://qastaging/tarmac

Proposed by Paul Hummer
Status: Merged
Approved by: Paul Hummer
Approved revision: 393
Merged at revision: 388
Proposed branch: lp://qastaging/~rockstar/tarmac/die-makefile-die
Merge into: lp://qastaging/tarmac
Diff against target: 117 lines (+67/-29)
2 files modified
Makefile (+0/-28)
setup.py (+67/-1)
To merge this branch: bzr merge lp://qastaging/~rockstar/tarmac/die-makefile-die
Reviewer Review Type Date Requested Status
dobey Approve
Paul Hummer Pending
Review via email: mp+49671@code.qastaging.launchpad.net

Commit message

Kill the Makefile

Description of the change

I killed the Makefile. Rodney and I had already talked about it, and it didn't take too much effort for Rodney to convince me that we don't need it.

All the functionality has been ported over to distutils stuff, except for test-fail, which I couldn't find a use for anywhere.

To post a comment you must log in.
Revision history for this message
dobey (dobey) wrote :

The clean command needs to derive from the one provided by distutils and chain up to it. For a simple example, the ubuntuone-storage-protocol clean command does this:

http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-storage-protocol/trunk/view/head:/setup.py#L57

review: Needs Fixing
393. By Paul Hummer

CleanCommand now DTRT

Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches