Merge lp://qastaging/~rockstar/ubuntuone-ios-music/gesture-icons into lp://qastaging/ubuntuone-ios-music
Proposed by
Paul Hummer
| Status: | Merged |
|---|---|
| Approved by: | Zachery Bir |
| Approved revision: | 229 |
| Merged at revision: | 227 |
| Proposed branch: | lp://qastaging/~rockstar/ubuntuone-ios-music/gesture-icons |
| Merge into: | lp://qastaging/ubuntuone-ios-music |
| Diff against target: |
152 lines (+63/-4) 4 files modified
U1Music.xcodeproj/project.pbxproj (+32/-0) controls/SongUITableView.h (+1/-0) controls/SongUITableView.m (+29/-4) view_controllers/AlbumViewController.m (+1/-0) |
| To merge this branch: | bzr merge lp://qastaging/~rockstar/ubuntuone-ios-music/gesture-icons |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zachery Bir | Approve | ||
|
Review via email:
|
|||
Commit message
Fix icons on the swipe right gesture.
Description of the change
I broke this out of the accidental mega-branch. Here's what it does:
- Add in the icons I forgot to add it earlier.
- Add in a setProgress: method, and make setCached use it.
- Make the view keep better track of its state in cases where we need to make icon changes based on its state (a small, but meaningful edge case in particular)
To post a comment you must log in.
Revision history for this message
| Zachery Bir (urbanape) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
