Merge lp://qastaging/~rockstar/ubuntuone-ios-music/ios-round-two into lp://qastaging/ubuntuone-ios-music
Proposed by
Paul Hummer
| Status: | Merged |
|---|---|
| Approved by: | Paul Hummer |
| Approved revision: | 235 |
| Merged at revision: | 231 |
| Proposed branch: | lp://qastaging/~rockstar/ubuntuone-ios-music/ios-round-two |
| Merge into: | lp://qastaging/ubuntuone-ios-music |
| Prerequisite: | lp://qastaging/~rockstar/ubuntuone-ios-music/ios5-round-one |
| Diff against target: |
224 lines (+20/-10) 14 files modified
Dependencies/oauthconsumer/OAMutableURLRequest.m (+2/-1) Dependencies/oauthconsumer/OAToken.m (+1/-1) Dependencies/oauthconsumer/OATokenManager.m (+2/-0) Other Sources/U1MusicAppDelegate.m (+2/-0) controls/SongUITableView.m (+2/-0) utilities/StreamingPlayer.m (+2/-2) utilities/U1HTTPResponse.m (+0/-1) utilities/U1LocalMusicServer.m (+2/-2) utilities/operations/Downloader.m (+2/-0) utilities/operations/U1ChunkDownloadOperation.m (+1/-0) view_controllers/PlaylistEditAlbumListViewController.m (+1/-1) view_controllers/PlaylistEditArtistListViewController.m (+1/-1) view_controllers/PlaylistEditSongListViewController.m (+1/-1) view_controllers/U1MigrationViewController.m (+1/-0) |
| To merge this branch: | bzr merge lp://qastaging/~rockstar/ubuntuone-ios-music/ios-round-two |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zachery Bir | Approve | ||
|
Review via email:
|
|||
Commit message
Fix potential memory leaks
Description of the change
While trying to ARC-ify things last week, I found a bunch of memory leaks and "potential" memory leaks (and learned a bit more about Instruments). Here's a shallow branch that fixes the trivial ones. There are still a few that problems, but I didn't want to invest too much time into this.
To post a comment you must log in.
Revision history for this message
| Ubuntu One Auto Pilot (otto-pilot) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Do it.