Merge lp://qastaging/~rockstar/ubuntuone-ios-music/more-little-changes into lp://qastaging/ubuntuone-ios-music
Proposed by
Paul Hummer
| Status: | Merged |
|---|---|
| Approved by: | Paul Hummer |
| Approved revision: | 269 |
| Merged at revision: | 246 |
| Proposed branch: | lp://qastaging/~rockstar/ubuntuone-ios-music/more-little-changes |
| Merge into: | lp://qastaging/ubuntuone-ios-music |
| Prerequisite: | lp://qastaging/~rockstar/ubuntuone-ios-music/settings-view |
| Diff against target: |
307 lines (+143/-31) 5 files modified
Music/Models/Song.m (+1/-1) Music/Models/UOModel.m (+0/-17) Music/Storyboard_iPhone.storyboard (+125/-8) Music/Utilities/UODownloader.m (+1/-2) U1Music.xcodeproj/project.pbxproj (+16/-3) |
| To merge this branch: | bzr merge lp://qastaging/~rockstar/ubuntuone-ios-music/more-little-changes |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michał Karnicki (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Set the build version to bzr release number.
Description of the change
With the backlog of reviews, here's two little things that I thought I'd do quick. The first is a trivial change to highlight tapped table cells in grey, rather than blue.
The other change is to set the build version of the built app based on the bzr revno. I figured out a way to do this on the copied plist, rather than the source controlled plist, so this works out well for us, as long as we only roll out from trunk, and I'm pretty committed to do just that (we weren't very committed to that previously).
To post a comment you must log in.
Revision history for this message
| Michał Karnicki (karni) | # |
review:
Approve
Revision history for this message
| Ubuntu One Auto Pilot (otto-pilot) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The prerequisite https:/