Merge lp://qastaging/~rockstar/ubuntuone-ios-music/ui-fine-tweaks into lp://qastaging/ubuntuone-ios-music
Proposed by
Paul Hummer
| Status: | Merged |
|---|---|
| Approved by: | Paul Hummer |
| Approved revision: | 254 |
| Merged at revision: | 242 |
| Proposed branch: | lp://qastaging/~rockstar/ubuntuone-ios-music/ui-fine-tweaks |
| Merge into: | lp://qastaging/ubuntuone-ios-music |
| Diff against target: |
435 lines (+118/-75) 10 files modified
Music/Models/Album.h (+1/-0) Music/Models/Album.m (+3/-1) Music/Models/Song.h (+5/-5) Music/Storyboard_iPhone.storyboard (+62/-45) Music/UOMusic.xcdatamodeld/UOMusic.xcdatamodel/contents (+7/-6) Music/View Controllers/AlbumViewController.m (+6/-4) Music/View Controllers/ArtistViewController.m (+5/-4) Music/View Controllers/SongsViewController.m (+1/-0) Music/Views/Table Cells/SongCell.h (+7/-0) Music/Views/Table Cells/SongCell.m (+21/-10) |
| To merge this branch: | bzr merge lp://qastaging/~rockstar/ubuntuone-ios-music/ui-fine-tweaks |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mike McCracken (community) | Approve | ||
| Michał Karnicki (community) | Approve | ||
|
Review via email:
|
|||
Commit message
This branch does the following small tweaks:
- Displays the song duration and (where applicable) track number in the song table cell.
- Sorts album's song listing by track number
- Sorts artist's song list by year released
- Sets ArtistViewContr
- Sets AlbumViewController title to the album's name
Description of the change
This branch does the following small tweaks:
- Displays the song duration and (where applicable) track number in the Song table cell.
- Sorts album's song listing by track number
- Sorts artist's song list by year released
- Sets ArtistViewContr
- Sets AlbumViewController title to the album's name
This required some changes to the Core Data model.
To post a comment you must log in.
Revision history for this message
| Michał Karnicki (karni) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I am pleased with the content of this changeset.