Evolution Indicator

Merge lp://qastaging/~rodrigo-moya/evolution-indicator/port-to-3-0 into lp://qastaging/evolution-indicator

  1. port-to-3-0
  2. Merge into trunk
Proposed by Rodrigo Moya
Status: Merged
Merged at revision: 78
Proposed branch: lp://qastaging/~rodrigo-moya/evolution-indicator/port-to-3-0
Merge into: lp://qastaging/evolution-indicator
Diff against target: 100 lines (+28/-6)
2 files modified
configure.ac (+15/-4)
src/evolution-indicator.c (+13/-2)
To merge this branch: bzr merge lp://qastaging/~rodrigo-moya/evolution-indicator/port-to-3-0
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+62653@code.qastaging.launchpad.net

Description of the change

Make it build with evolution 3.0 stack

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

The changes seems good, but evolution is now using libgtkhtml-editor-4.0.pc and not 3.14 anymore. Can you make the change so that we can drop 3.14 from the CD?

review: Needs Information
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

just to be a little bit more clear,

22 + GTKHTML_EDITOR=gtkhtml-editor-3.14,
is in PKG_CHECK_EXISTS(evolution-plugin, which seems to be the 2.0 version, but this PKG_CHECK_EXISTS is itself in 17 +PKG_CHECK_EXISTS(evolution-plugin-3.0,
hence the fact I'm puzzled :)

lp://qastaging/~rodrigo-moya/evolution-indicator/port-to-3-0 updated
79. By Rodrigo Moya

Fix C&P code

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

after discussion on IRC, approved then :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches