Merge lp://qastaging/~rodsmith/checkbox/fix-net-speed-detection into lp://qastaging/checkbox
Proposed by
Rod Smith
| Status: | Merged |
|---|---|
| Approved by: | Sylvain Pineau |
| Approved revision: | 4509 |
| Merged at revision: | 4521 |
| Proposed branch: | lp://qastaging/~rodsmith/checkbox/fix-net-speed-detection |
| Merge into: | lp://qastaging/checkbox |
| Diff against target: |
20 lines (+2/-2) 1 file modified
providers/plainbox-provider-checkbox/bin/network (+2/-2) |
| To merge this branch: | bzr merge lp://qastaging/~rodsmith/checkbox/fix-net-speed-detection |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jeff Lane | Approve | ||
| Sylvain Pineau (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
On a Cavium Thunder (ARM64) system, ethtool outputs less information than on (most? all?) AMD64 systems. This causes the network test to fail to identify the network speed, resulting in a default "pass" result even when the network is under-performing. This patch broadens the scope of the search for the link speed in the network test, causing correct behavior on both AMD64 and Cavium systems -- that is, a reported failure when the network test actually fails.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Weird indeed. Thanks for the fix Rod