Merge lp://qastaging/~rodsmith/hwcert-tools/get-hw-info into lp://qastaging/~hardware-certification/hwcert-tools/reporting-tools
| Status: | Merged |
|---|---|
| Approved by: | Daniel Manrique |
| Approved revision: | 151 |
| Merged at revision: | 151 |
| Proposed branch: | lp://qastaging/~rodsmith/hwcert-tools/get-hw-info |
| Merge into: | lp://qastaging/~hardware-certification/hwcert-tools/reporting-tools |
| Diff against target: |
109 lines (+105/-0) 1 file modified
certification_reports/summarize_hw.py (+105/-0) |
| To merge this branch: | bzr merge lp://qastaging/~rodsmith/hwcert-tools/get-hw-info |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
Commit message
New script (summarize_hw.py) to create a new type of summary report
Description of the change
This is a new script (summarize_hw.py) to satisfy a request from Craig Magina (via Andres Rodriquez) for summary information on which network chipsets were being used by certified servers. The resulting script is a little more general; it can be used to search for video hardware, USB hardware, etc. (See the comments in the first few lines of the script for use options.) The output includes a list of devices (with both PCI-IDs and descriptions) and the number of servers that use each option; for instance:
19a2:0710 (OneConnect 10Gb NIC (be3)): 5
14e4:16ae (NetXtreme II BCM57810 10 Gigabit Ethernet Multi Function): 1
14e4:168e (NetXtreme II BCM57810 10 Gigabit Ethernet): 2
This script is derived from my earlier summarize_pciids.py script.
Looks OK to me, I'd maybe add a full Canonical copyright header to the script, and perhaps your email address to the author line, but those are minor nitpicks. I'll approve as-is. Thanks!