Merge lp://qastaging/~roignac/shutter/bug552842 into lp://qastaging/shutter

Proposed by Vadim Rutkovsky
Status: Merged
Merged at revision: 848
Proposed branch: lp://qastaging/~roignac/shutter/bug552842
Merge into: lp://qastaging/shutter
Diff against target: 62 lines (+38/-0)
1 file modified
bin/shutter (+38/-0)
To merge this branch: bzr merge lp://qastaging/~roignac/shutter/bug552842
Reviewer Review Type Date Requested Status
Mario Kemper (Romario) Approve
Review via email: mp+25836@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Vadim Rutkovsky (roignac) wrote :

This fix also requires .pot, .po and .mo files rebuilt - not sure, if this is done automatically

Revision history for this message
Mario Kemper (Romario) (mario-kemper) wrote :

Please check the tooltip again and change the order of the strings:

$d->get("\$R = random character (e.g. $RRRR = ag4r)\n").
$d->get("%NN = counter");

Everything else looks fine.

review: Needs Fixing
Revision history for this message
Mario Kemper (Romario) (mario-kemper) wrote :

Even better ;-) ($RRRR needs to be escaped)

$d->get("\$R = random character (e.g. \$RRRR = ag4r)\n").
$d->get("%NN = counter");

Revision history for this message
Vadim Rutkovsky (roignac) wrote :

Ok, done in revision 849

849. By Vadim Rutkovsky <vadik@note>

Fixed a text in tooltip

Revision history for this message
Mario Kemper (Romario) (mario-kemper) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: