Ubuntu Notes app

Merge lp://qastaging/~rpadovani/reminders-app/1340686 into lp://qastaging/reminders-app

  1. 1340686
  2. Merge into trunk
Proposed by Riccardo Padovani
Status: Merged
Approved by: Michael Zanetti
Approved revision: 179
Merged at revision: 191
Proposed branch: lp://qastaging/~rpadovani/reminders-app/1340686
Merge into: lp://qastaging/reminders-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/app/qml/ui/NotesPage.qml (+1/-1)
To merge this branch: bzr merge lp://qastaging/~rpadovani/reminders-app/1340686
Reviewer Review Type Date Requested Status
David Planella Approve
Michael Zanetti (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+226615@code.qastaging.launchpad.net

Commit message

Fixed #1340686 - Selecting a notebook then add a note doesn't default the note to the notebook

Description of the change

Fixed #1340686 - Selecting a notebook then add a note doesn't default the note to the notebook

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:178
http://91.189.93.70:8080/job/reminders-app-ci/454/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/999
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/999/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/150

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/454/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

one small inline nitpick. otherwise looks good

review: Needs Fixing
Revision history for this message
Michael Zanetti (mzanetti) wrote :

actually, you don't even need the if(), do you? If filter is an empty string it'll be the same calling it without an arg...

lp://qastaging/~rpadovani/reminders-app/1340686 updated
179. By Riccardo Padovani

Improved implementation of filter

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

On Mon, Jul 14, 2014 at 07:44:13AM -0000, Michael Zanetti wrote:
>
> actually, you don't even need the if(), do you? If filter is an empty string it'll be the same calling it without an arg...

Yes, you're right: I thought that when filter is undefined causes problem with
the function, but works without problem, just tested.

Thanks,
--
Riccardo Padovani
www.rpadovani.com

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:179
http://91.189.93.70:8080/job/reminders-app-ci/456/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1006
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1006/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/152

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/456/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

yep, fine with that :)

review: Approve
Revision history for this message
David Planella (dpm) wrote :

Top-approving after discussion on a hangout

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches