Ubuntu Notes app

Merge lp://qastaging/~rpadovani/reminders-app/remove-unused-components into lp://qastaging/reminders-app

  1. remove-unused-components
  2. Merge into trunk
Proposed by Riccardo Padovani
Status: Needs review
Proposed branch: lp://qastaging/~rpadovani/reminders-app/remove-unused-components
Merge into: lp://qastaging/reminders-app
Diff against target: 237 lines (+2/-168)
3 files modified
src/app/qml/components/NoteHeader.qml (+1/-3)
src/app/qml/components/NotesDelegate.qml (+1/-1)
src/app/qml/images/tags.svg (+0/-164)
To merge this branch: bzr merge lp://qastaging/~rpadovani/reminders-app/remove-unused-components
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 🦄 (community) Needs Fixing
Jenkins Bot continuous-integration Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+271850@code.qastaging.launchpad.net

Commit message

Remove unused files

Description of the change

Remove unused CameraComponents/ directory
Replace our custom tag icon with the one from the suru theme

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:494
http://91.189.93.70:8080/job/reminders-app-ci/790/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/212

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/790/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:494
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/22/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/105/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/22/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

This fails to launch here for me...

file:///opt/click.ubuntu.com/com.ubuntu.reminders/0.5.494/qml/reminders.qml:564:23: Type NotesPage unavailable
                     page: NotesPage {
                           ^
file:///opt/click.ubuntu.com/com.ubuntu.reminders/0.5.494/qml/ui/NotesPage.qml:44:30: Type EditNotePage unavailable
         bottomEdgePageComponent: EditNotePage {
                                  ^
file:///opt/click.ubuntu.com/com.ubuntu.reminders/0.5.494/qml/ui/EditNotePage.qml:39:5: Type EditNoteView unavailable
         EditNoteView {
         ^
file:///opt/click.ubuntu.com/com.ubuntu.reminders/0.5.494/qml/ui/EditNoteView.qml:158:22: Type NoteHeader unavailable
                          NoteHeader {
                          ^
file:///opt/click.ubuntu.com/com.ubuntu.reminders/0.5.494/qml/components/NoteHeader.qml:129:29: Cannot assign to non-existent property "icon"
                                 icon: "tag"
                                 ^
UbuntuClipboard - Got invalid serialized mime data. Ignoring it.

review: Needs Fixing
Reply

Unmerged revisions

494. By Riccardo Padovani

Use tag icon from the suru icon theme

493. By Riccardo Padovani

Remove CameraComponents images, we now use content hub

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches