Merge lp://qastaging/~rpadovani/ubuntu-calculator-app/bumpToolkit into lp://qastaging/ubuntu-calculator-app

PASSED: Continuous integration, rev:235
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/11/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/118/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/11/rebuild

PASSED: Continuous integration, rev:235
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/368/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-vivid-amd64-ci/90

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/368/rebuild

Some small inline comment.

I will intense test it later today.

PASSED: Continuous integration, rev:236
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/12/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/120/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/12/rebuild

Thanks!

PASSED: Continuous integration, rev:237
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/13/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/121/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/13/rebuild

Thanks Riccardo.
I noticed that following warnings are appearing:
file:///home/kosiorek/dev/core/bumpToolkit/app/upstreamcomponents/PageWithBottomEdge.qml:144:5: QML UbuntuShape: 'color' is deprecated. Use 'backgroundColor', 'secondaryBackgroundColor' and 'backgroundMode' instead.

and

uses confusion which is the active page that sets the title and actions.
file:///home/kosiorek/dev/core/bumpToolkit/app/ubuntu-calculator-app.qml:253:9: QML PageWithBottomEdge: Binding loop detected for property "height"
file:///home/kosiorek/dev/core/bumpToolkit/app/ubuntu-calculator-app.qml:253:9: QML PageWithBottomEdge: Binding loop detected for property "height"
file:///home/kosiorek/dev/core/bumpToolkit/app/ubuntu-calculator-app.qml:538:13: QML ScrollableView: Binding loop detected for property "contentHeight"
file:///home/kosiorek/dev/core/bumpToolkit/app/ubuntu-calculator-app.qml:253:9: QML PageWithBottomEdge: Binding loop detected for property "flickable"

and error during scrolling selected entries:
file:///home/kosiorek/dev/core/bumpToolkit/app/ui/ScrollableView.qml:37: TypeError: Cannot read property 'y' of null

Could you please try to fix that?

There are also errors:
file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/1.3/PageWrapperUtils.js:90: TypeError: Cannot read property 'createObject' of null

BTW The windows title is working perfectly now! No more "com.ubuntu.calculator" :-)

One more small issue:
When you run first time Calculator, the virtual keyboard is slighly shifted to bottom.
After first click, it moves in correct place.
Could you please take a look at this.

PASSED: Continuous integration, rev:240
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/14/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/125/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/14/rebuild

I fixed all the warnings, I'm still investigating about the virtual keyboard position

I'm quite puzzled about the bug, it happens randomly, not all the time, probably 1 on 3. I have no idea of which is the root case, and I tried a lot of different things.

I'm sure we've already seen something like this, but I don't remember how we fixed it.
If you have any suggestions, please let me know!

So, some progress on this.

It seems that when the app is loaded the pagestack changes its height a lot of times:
if you add onHeightChanged: console.log('pagestack ' + height) on line 254 of ubuntu-calculator-app.qml when you start the app you have something like this:

qml: pagestack 565.7091325559794
qml: pagestack 560
qml: pagestack 565.3556258961664
qml: pagestack 560
qml: pagestack 565.0021192363535
qml: pagestack 560
qml: pagestack 564.6486125765405
qml: pagestack 560
qml: pagestack 564.2951059167276
qml: pagestack 560
qml: pagestack 563.9415992569145
qml: pagestack 560
qml: pagestack 563.5880925971016
qml: pagestack 560
qml: pagestack 563.2345859372887
qml: pagestack 560
qml: pagestack 562.8810792774757
qml: pagestack 560
qml: pagestack 562.5275726176627
qml: pagestack 560
qml: pagestack 562.1740659578497
qml: pagestack 560
qml: pagestack 561.8205592980368
qml: pagestack 560
qml: pagestack 561.4670526382238
qml: pagestack 560
qml: pagestack 561.1135459784108
qml: pagestack 560
qml: pagestack 560.7600393185979
qml: pagestack 560
qml: pagestack 560.4065326587848
qml: pagestack 560
qml: pagestack 560.0746782818856
qml: pagestack 560

I need to understand what's the root cause of this change - when I'll be able to isolate it, I think I'll be able to fix it

Investigating more, it is related to the header. If I don't hide the header it doesn't happen.

I think is related to https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1518002, need to investigate further to find a workaround

PASSED: Continuous integration, rev:241
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/23/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/169/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/23/rebuild

Okay, I found a workaround until the bug is fixed upstream.

It introduces a bug in the desktop mode (when you resize the window, the app scrolls down) but I think is way less important that this one

Hello Riccardo.

Could you please submit bug report for that issue?
It will be great to resolve it upstream.

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/calculator-app-autolanding/88/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/405/console

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/calculator-app-autolanding/89/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/407/console

There are same conflicts. Please resolve them. After that just top approve that.

PASSED: Continuous integration, rev:242
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/24/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/175/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/24/rebuild

Thanks Bartosz, I fixed conflicts.

The bug upstream is https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1518002