Merge lp://qastaging/~rpadovani/webbrowser-app/go-fullscreen-landscape-phone into lp://qastaging/webbrowser-app
Proposed by
Riccardo Padovani
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~rpadovani/webbrowser-app/go-fullscreen-landscape-phone |
| Merge into: | lp://qastaging/webbrowser-app |
| Diff against target: |
31 lines (+14/-0) 1 file modified
src/app/BrowserWindow.qml (+14/-0) |
| To merge this branch: | bzr merge lp://qastaging/~rpadovani/webbrowser-app/go-fullscreen-landscape-phone |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve | |
| Olivier Tilloy | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
When on phone go fullscreen, as per bug #1426347
Description of the change
When on phone (height in landscape mode < units.gu(51)) go fullscreen, as per bug #1426347
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Unmerged revisions
- 967. By Riccardo Padovani
-
Use width to understand when it's a tablet, as per designers request
- 966. By Riccardo Padovani
-
Go full screen in landscape mode on phones
- 965. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 964. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 963. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This is not the right implementation: the app’s window should go fullscreen, not the webview. Even then, I’m not too sure about that requirement at the app level: it should probably be a system-wide behaviour, so it requires more discussion before actually implementing it.