webbrowser-app

Merge lp://qastaging/~rpadovani/webbrowser-app/suggestions-list-visual-update into lp://qastaging/webbrowser-app

  1. suggestions-list-visual-update
  2. Merge into trunk
Proposed by Riccardo Padovani
Status: Needs review
Proposed branch: lp://qastaging/~rpadovani/webbrowser-app/suggestions-list-visual-update
Merge into: lp://qastaging/webbrowser-app
Diff against target: 129 lines (+31/-11)
3 files modified
src/app/webbrowser/Browser.qml (+3/-3)
src/app/webbrowser/Suggestion.qml (+10/-1)
src/app/webbrowser/Suggestions.qml (+18/-7)
To merge this branch: bzr merge lp://qastaging/~rpadovani/webbrowser-app/suggestions-list-visual-update
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+257724@code.qastaging.launchpad.net

Commit message

Update the visual design of suggestions list according to design spec

Description of the change

Update the visual design of suggestions list according to design spec.

In spec there is specified the size of text. IMO is too small now, and was better the previous size

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:988
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1707/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2518/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/464
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/464
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/464/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/464
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2180/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2516
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2516/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20007

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1707/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://qastaging/~rpadovani/webbrowser-app/suggestions-list-visual-update updated
989. By Riccardo Padovani

Merge from upstream and fix conflicts

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:989
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1883/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3183
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/640
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/640
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/640/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/640
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2676
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3181
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3181/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/21163

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1883/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

989. By Riccardo Padovani

Merge from upstream and fix conflicts

988. By Riccardo Padovani

Update visual design of suggestions list

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: