Linaro Image Tools

Merge lp://qastaging/~rsalveti/linaro-image-tools/generic-oe-support into lp://qastaging/linaro-image-tools/11.11

generic-oe-support
Merge into trunk

Proposed by Ricardo Salveti on 2012-08-09

Status:	Merged
Approved by:	James Tunnicliffe on 2012-08-09
Approved revision:	549
Merged at revision:	545
Proposed branch:	lp://qastaging/~rsalveti/linaro-image-tools/generic-oe-support
Merge into:	lp://qastaging/linaro-image-tools/11.11
Diff against target:	1068 lines (+367/-240) 7 files modified linaro-hwpack-install (+193/-147) linaro-media-create (+38/-11) linaro_image_tools/media_create/android_boards.py (+4/-1) linaro_image_tools/media_create/boards.py (+45/-41) linaro_image_tools/media_create/chroot_utils.py (+17/-9) linaro_image_tools/media_create/rootfs.py (+3/-3) linaro_image_tools/media_create/tests/test_media_create.py (+67/-28)
To merge this branch:	bzr merge lp://qastaging/~rsalveti/linaro-image-tools/generic-oe-support
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
James Tunnicliffe (community)		2012-08-09	Approve on 2012-08-09
Review via email: mp+118857@code.qastaging.launchpad.net

Description of the change

Adding support for generic linux based images, like OpenEmbedded.

The goal is to avoid using dpkg/apt when the rootfs used is not based on debian/ubuntu, and for that, the only generic way to support a hwpack is to use just the bootloader and the kernel packages, as they are not dependent on the rootfs.

These patches add one extra option to the hwpack-install script, to allow the user to request the script to just extract the kernel packages, and make sure the modules are properly in place. As hwpack-install is used by linaro-media-create, we try to identify the rootfs structure and type, to see if it should just extract or install the packages with apt.

As we can't depend on the rootfs type, we can force the rootfs to use UUID to identify the rootfs (as this is part of the initrd code). In case the user wants to just extract the kernel, the boot commands should reflect the usage of just the uImage file, together with the bootloader.

Tested with the OE lamp based image, and with lt-panda (to see if nothing else is broken).

Revision history for this message

James Tunnicliffe (dooferlad) wrote on 2012-08-09:

Looks fine. Gosh I wish we had moved block detection and change classification in the diff viewer (wouldn't it be nice if all the places where a variable were renamed could be just ticked off then ignored). Anyway, one small change, but I will make it and them merge:

409 + # if not a debian compatible system, just extract the kernel packages
410 + extract_kpkgs = False
411 + if not path_in_tarfile_exists(
412 + filesystem_dir + '/etc/debian_version', args.binary):
413 + extract_kpkgs = True

We should use os.path.join(filesystem_dir, '/etc/debian_version') for path strings.

Thanks.

review: Approve

Revision history for this message

Ricardo Salveti (rsalveti) wrote on 2012-08-09:

On Thu, Aug 9, 2012 at 7:42 AM, James Tunnicliffe
<email address hidden> wrote:
> Review: Approve
>
> Looks fine. Gosh I wish we had moved block detection and change classification in the diff viewer (wouldn't it be nice if all the places where a variable were renamed could be just ticked off then ignored). Anyway, one small change, but I will make it and them merge:
>
> 409 + # if not a debian compatible system, just extract the kernel packages
> 410 + extract_kpkgs = False
> 411 + if not path_in_tarfile_exists(
> 412 + filesystem_dir + '/etc/debian_version', args.binary):
> 413 + extract_kpkgs = True
>
> We should use os.path.join(filesystem_dir, '/etc/debian_version') for path strings.