unity-mir

Merge lp://qastaging/~rsalveti/unity-mir/removing_armhf_hardcoded_path_QtWebProcess into lp://qastaging/unity-mir

  1. removing_armhf_hardcoded_path_QtWebProcess
  2. Merge into trunk
Proposed by Ricardo Salveti
Status: Merged
Approved by: Gerry Boland
Approved revision: 198
Merged at revision: 202
Proposed branch: lp://qastaging/~rsalveti/unity-mir/removing_armhf_hardcoded_path_QtWebProcess
Merge into: lp://qastaging/unity-mir
Diff against target: 39 lines (+6/-1)
3 files modified
src/modules/Unity/Application/application_manager.cpp (+1/-1)
src/modules/Unity/Application/proc_info.cpp (+4/-0)
src/modules/Unity/Application/proc_info.h (+1/-0)
To merge this branch: bzr merge lp://qastaging/~rsalveti/unity-mir/removing_armhf_hardcoded_path_QtWebProcess
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Ricardo Mendoza Pending
Review via email: mp+210528@code.qastaging.launchpad.net

Commit message

Using str.contains to find out if the cmdline is from a QtWebProcess process

Description of the change

Using str.contains to find out if the cmdline is from a QtWebProcess process

And remove the hardcoded armhf library path (usr/lib/arm-linux-gnueabihf).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:198
http://jenkins.qa.ubuntu.com/job/unity-mir-ci/290/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-amd64-ci/153
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-ci/154
        deb: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-ci/154/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-i386-ci/153

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-mir-ci/290/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

works for me, x86 support I suppose

I've to ask you to fill out this checklist before I can top-approve:
https://wiki.ubuntu.com/Process/Merges/Checklists/Unity-Mir

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes, all good

 * Did CI run pass? If not, please explain why.
Was ok

review: Approve
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

 * Are there any related MPs required for this MP to build/function as expected? Please list.

No.

 * Did you perform an exploratory manual test run of your code change and any related functionality?

Yes.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

Not affecting packaging.

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

> works for me, x86 support I suppose

Yes, so I can drop another custom package from my x86 ppa :-)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches