Merge lp://qastaging/~rvb/maas/no-dns-config-pregeneration into lp://qastaging/~maas-committers/maas/trunk
Status: | Merged |
---|---|
Approved by: | Raphaël Badin |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2488 |
Proposed branch: | lp://qastaging/~rvb/maas/no-dns-config-pregeneration |
Merge into: | lp://qastaging/~maas-committers/maas/trunk |
Diff against target: |
776 lines (+108/-326) 7 files modified
src/maasserver/dns.py (+17/-9) src/maasserver/tests/test_dns.py (+26/-43) src/provisioningserver/dns/config.py (+36/-94) src/provisioningserver/dns/tests/test_config.py (+27/-107) src/provisioningserver/dns/tests/test_utils.py (+0/-38) src/provisioningserver/dns/utils.py (+0/-32) src/provisioningserver/tests/test_tasks.py (+2/-3) |
To merge this branch: | bzr merge lp://qastaging/~rvb/maas/no-dns-config-pregeneration |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Julian Edwards (community) | Approve | ||
Review via email:
|
Commit message
Drop the pre-population of the zone files with generated hostnames.
Description of the change
Back when the DNS work got started, we decided to pre-fill the forward and reverse zone files with mappings from all the IPs in the network to hostnames generated from these IP addresses (e.g. 192-168-
See https:/
This was tested on my NUCs and in the CI lab.
Surprisingly easy for a big branch! Lots of removed code, always nice to see. No comments inline other than what we discussed. I have some Friday Brain Fog so get a second opinion if you don't trust me :)