Merge lp://qastaging/~rvb/maas/no-dns-config-pregeneration into lp://qastaging/~maas-committers/maas/trunk

Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: no longer in the source branch.
Merged at revision: 2488
Proposed branch: lp://qastaging/~rvb/maas/no-dns-config-pregeneration
Merge into: lp://qastaging/~maas-committers/maas/trunk
Diff against target: 776 lines (+108/-326)
7 files modified
src/maasserver/dns.py (+17/-9)
src/maasserver/tests/test_dns.py (+26/-43)
src/provisioningserver/dns/config.py (+36/-94)
src/provisioningserver/dns/tests/test_config.py (+27/-107)
src/provisioningserver/dns/tests/test_utils.py (+0/-38)
src/provisioningserver/dns/utils.py (+0/-32)
src/provisioningserver/tests/test_tasks.py (+2/-3)
To merge this branch: bzr merge lp://qastaging/~rvb/maas/no-dns-config-pregeneration
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+223891@code.qastaging.launchpad.net

Commit message

Drop the pre-population of the zone files with generated hostnames.

Description of the change

Back when the DNS work got started, we decided to pre-fill the forward and reverse zone files with mappings from all the IPs in the network to hostnames generated from these IP addresses (e.g. 192-168-10-253.<domain> <--> 192.168.10.253); This was a simplification as it meant the hostnames for real nodes would simply need to be translated into CNAME records on top of the pre-filled A/PTR structure (i.e. no update of the reverse zone files). Now that we're adding support for IPv6, this simplification is making things more complex as it's forcing us to manipulate IP addresses in a way that is IPv4-specific. We've been talking about getting rid of this pre-population for a while now so I thought it was a good occasion to do it and make the IPv6 work most simple (i.e. kill two birds with one stone).

See https://docs.google.com/a/canonical.com/document/d/128QR_3ANyWIY6_K6YG2WzAJitl_Aevt23S28HjastiE/edit?usp=drive_web for a more detailed description of this change.

This was tested on my NUCs and in the CI lab.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Surprisingly easy for a big branch! Lots of removed code, always nice to see. No comments inline other than what we discussed. I have some Friday Brain Fog so get a second opinion if you don't trust me :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.