Merge lp://qastaging/~rvb/maas/test-bug-1442162 into lp://qastaging/~maas-committers/maas/trunk
Proposed by
Raphaël Badin
| Status: | Merged |
|---|---|
| Approved by: | Raphaël Badin |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 3810 |
| Proposed branch: | lp://qastaging/~rvb/maas/test-bug-1442162 |
| Merge into: | lp://qastaging/~maas-committers/maas/trunk |
| Diff against target: |
222 lines (+46/-38) 2 files modified
src/maasserver/api/nodes.py (+3/-1) src/maasserver/api/tests/test_nodes.py (+43/-37) |
| To merge this branch: | bzr merge lp://qastaging/~rvb/maas/test-bug-1442162 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gavin Panella (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Fix spurious test (and related code): sort node listing by id.
Description of the change
- It doesn't really make sense to sort by uuids (which are random —well, they should be, uuid1() isn't completely random). Also, the code was implicitly relying on the system_id to be generated "in order" which is pure luck (see bug 1379826 for details).
- Couple of drive-by fixes.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for fixing this.