Merge lp://qastaging/~sajoupa/landscape-charm/op-framework-db-connect-to-primary into lp://qastaging/~mitchburton/landscape-charm/op-framework

Proposed by Laurent Sesquès
Status: Merged
Approved by: Mitch Burton
Approved revision: 424
Merge reported by: Mitch Burton
Merged at revision: not available
Proposed branch: lp://qastaging/~sajoupa/landscape-charm/op-framework-db-connect-to-primary
Merge into: lp://qastaging/~mitchburton/landscape-charm/op-framework
Diff against target: 18 lines (+4/-2)
1 file modified
src/charm.py (+4/-2)
To merge this branch: bzr merge lp://qastaging/~sajoupa/landscape-charm/op-framework-db-connect-to-primary
Reviewer Review Type Date Requested Status
Mitch Burton Approve
Review via email: mp+435019@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Laurent Sesquès (sajoupa) wrote :

The current version of the charm fails to deploy in CI and staging with multiple postgresql units, because it can't update the DB schema.
This is because unit_data["host"] can return the IP of any postgresql unit, including the secondary, which is read-only.
This commit will ensure that landscape-server connects to the primary.

Revision history for this message
Mitch Burton (mitchburton) wrote :

+1 LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: