Merge lp://qastaging/~salgado/launchpad-work-items-tracker/linaro-use-lp-workitems-property into lp://qastaging/~linaro-automation/launchpad-work-items-tracker/linaro

Proposed by Guilherme Salgado
Status: Merged
Approved by: Mattias Backman
Approved revision: 334
Merged at revision: 333
Proposed branch: lp://qastaging/~salgado/launchpad-work-items-tracker/linaro-use-lp-workitems-property
Merge into: lp://qastaging/~linaro-automation/launchpad-work-items-tracker/linaro
Diff against target: 52 lines (+19/-9)
1 file modified
collect (+19/-9)
To merge this branch: bzr merge lp://qastaging/~salgado/launchpad-work-items-tracker/linaro-use-lp-workitems-property
Reviewer Review Type Date Requested Status
Mattias Backman (community) Approve
Linaro Infrastructure Pending
Review via email: mp+96152@code.qastaging.launchpad.net

Description of the change

Change lp_import_blueprint_workitems to get work items from the workitems_text
API property instead of the whiteboard.

Soon we'll be migrating all work items in LP from the whiteboard to a new
field. This will allow us to implement things like
https://dev.launchpad.net/Projects/WorkItems in Launchpad.

Because of that, lp-wi-tracker will have to extract work items from the new
property (workitems_text), which uses the existing format for work items.

To post a comment you must log in.
Revision history for this message
Mattias Backman (mabac) wrote :

> Because of that, lp-wi-tracker will have to extract work items from the new
> property (workitems_text), which uses the existing format for work items.

It just struck me that we don't use exactly the same format. I thought it would be redundant to have the leading "Work items:" line in the Work Items text area, so I omitted that. Perhaps we should tweak workitems_text to include that line for work item blocks that are not milestoned.

If we don't do that we need to do

    if bp.workitems_text:
        in_workitems_block = True
        for l in bp.workitems_text.splitlines():
            if not in_workitems_block:

so we assume we're in a workitems_block from the beginning of the workitems_text field. If there are no non-milestoned work items, the field would of course start with a "Work items for 2012.x:" line but then the entire bp should be retargetted.

review: Needs Fixing
334. By Guilherme Salgado

Pull work items from both the whiteboard and the new .workitems_text property

Revision history for this message
Mattias Backman (mabac) wrote :

Looks good to me.

review: Approve
Revision history for this message
Mattias Backman (mabac) wrote :

I see that it has been running on staging for a while too, so there should be no problems.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches