Offspring

Merge lp://qastaging/~salgado/offspring/acl-sidebar into lp://qastaging/~linaro-automation/offspring/linaro

  1. acl-sidebar
  2. Merge into linaro
Proposed by Guilherme Salgado
Status: Merged
Approved by: James Tunnicliffe
Approved revision: 80
Merge reported by: Guilherme Salgado
Merged at revision: not available
Proposed branch: lp://qastaging/~salgado/offspring/acl-sidebar
Merge into: lp://qastaging/~linaro-automation/offspring/linaro
Prerequisite: lp://qastaging/~salgado/offspring/acl-editor
Diff against target: 96 lines (+48/-1)
3 files modified
lib/offspring/web/queuemanager/views.py (+2/-0)
lib/offspring/web/templates/base.html (+7/-1)
lib/offspring/web/templates/queuemanager/project_details.html (+39/-0)
To merge this branch: bzr merge lp://qastaging/~salgado/offspring/acl-sidebar
Reviewer Review Type Date Requested Status
James Tunnicliffe (community) Approve
Review via email: mp+78885@code.qastaging.launchpad.net

Description of the change

Show a padlock on the heading of private project/build pages and also list the users who are allowed to see a given project, followed by a link to edit that list.

To post a comment you must log in.
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

I haven't tested it, but it looks fine. Not sure if we need the "you can't see this page, but these people can" bit, but I think it should be left in while we get things running and demo it for the users. If they want to take it out, it should be simple enough.

review: Approve
Revision history for this message
Guilherme Salgado (salgado) wrote :

On Wed, 2011-10-12 at 15:34 +0000, James Tunnicliffe wrote:
> Review: Approve
>
> I haven't tested it, but it looks fine. Not sure if we need the "you can't see this page, but these people can" bit, but I think it should be left in while we get things running and demo it for the users. If they want to take it out, it should be simple enough.

Oh, but that's not shown if you don't have the rights to see the
project. If you don't have the rights all you get is HTTP 404 (one of my
previous branches do that) as if the project didn't exist.

Revision history for this message
Guilherme Salgado (salgado) wrote :

In fact this was merged into our integration branch (lp:~linaro-infrastructure/offspring/private-builds)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches