Offspring

Merge lp://qastaging/~salgado/offspring/build-lists into lp://qastaging/~linaro-automation/offspring/private-builds

  1. build-lists
  2. Merge into private-builds
Proposed by Guilherme Salgado
Status: Merged
Approved by: James Tunnicliffe
Approved revision: 80
Merged at revision: 60
Proposed branch: lp://qastaging/~salgado/offspring/build-lists
Merge into: lp://qastaging/~linaro-automation/offspring/private-builds
Diff against target: 105 lines (+60/-5)
2 files modified
lib/offspring/web/queuemanager/tests/test_views.py (+47/-0)
lib/offspring/web/queuemanager/views.py (+13/-5)
To merge this branch: bzr merge lp://qastaging/~salgado/offspring/build-lists
Reviewer Review Type Date Requested Status
James Tunnicliffe (community) Approve
Review via email: mp+79348@code.qastaging.launchpad.net

Description of the change

This branch changes the builds() view to be privacy aware, so that private builds are shown if the user is allowed to see them. It also adds the padlock icon to the project builds view (/builds/<projectname>), when the project is private.

To post a comment you must log in.
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Looks good.

review: Approve
Revision history for this message
Guilherme Salgado (salgado) wrote :

Thanks for the review, James

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches