OpenLP

Merge lp://qastaging/~sam92/openlp/bug-1552563 into lp://qastaging/openlp

  1. bug-1552563
  2. Merge into trunk
Proposed by Samuel Mehrbrodt
Status: Merged
Approved by: Tim Bentley
Approved revision: 2659
Merged at revision: 2655
Proposed branch: lp://qastaging/~sam92/openlp/bug-1552563
Merge into: lp://qastaging/openlp
Diff against target: 144 lines (+39/-37)
3 files modified
openlp/plugins/songs/lib/mediaitem.py (+10/-12)
tests/functional/openlp_plugins/songs/test_mediaitem.py (+29/-24)
tests/functional/openlp_plugins/songs/test_openlpimporter.py (+0/-1)
To merge this branch: bzr merge lp://qastaging/~sam92/openlp/bug-1552563
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Raoul Snyman Approve
Review via email: mp+293427@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2016-04-29.

Description of the change

Fix performance regression with Songbook search

The problem was that in each iteration the database was accessed (the song object).
Fixed this by loading all neccessary information directly in the query.

To post a comment you must log in.
Revision history for this message
Samuel Mehrbrodt (sam92) wrote : Posted in a previous version of this proposal

lp:~sam92/openlp/bug-1552563 (revision 2659)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1508/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1419/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1357/
[SUCCESS] https://ci.openlp.io/job/Branch-04a-Windows_Functional_Tests/1153/
[SUCCESS] https://ci.openlp.io/job/Branch-04b-Windows_Interface_Tests/744/
[SUCCESS] https://ci.openlp.io/job/Branch-05a-Code_Analysis/811/
[SUCCESS] https://ci.openlp.io/job/Branch-05b-Test_Coverage/679/

Revision history for this message
Raoul Snyman (raoul-snyman) :
review: Approve
Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.