Merge lp://qastaging/~sam92/openlp/bug-1695620 into lp://qastaging/openlp
| Status: | Superseded | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Proposed branch: | lp://qastaging/~sam92/openlp/bug-1695620 | ||||||||
| Merge into: | lp://qastaging/openlp | ||||||||
| Diff against target: |
720 lines (+289/-144) 7 files modified
openlp/core/lib/serviceitem.py (+5/-7) openlp/core/ui/maindisplay.py (+2/-2) openlp/core/ui/printserviceform.py (+5/-5) openlp/plugins/songs/lib/mediaitem.py (+43/-19) openlp/plugins/songs/lib/songstab.py (+74/-37) openlp/plugins/songs/songsplugin.py (+53/-3) tests/functional/openlp_plugins/songs/test_mediaitem.py (+107/-71) |
||||||||
| To merge this branch: | bzr merge lp://qastaging/~sam92/openlp/bug-1695620 | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Raoul Snyman | Disapprove | ||
| Tim Bentley | Needs Fixing | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2017-06-12.
Description of the change
make use of pystache for footer generation being configurable in song settings
- removed now obsolete and via template better configurable options to display "songbook", "written by" and "copyright" information in footer
- added explanation box for so far used settings as pystache placeholders
- added songs configuration setting for template including reset button
- added default template replacing currently existing configuration as best as possible (should be backwards compatible or at least be adaptable to correspond to former settings)
- write and adapt tests for new and removed functionality
- Added some more available fields in the footer: Alternate Title, CCLI Number, Topics, Authors (all music, all words)
You need to run CI on this to show the success of tests.
Not sure why but this request did a full download when I did a check out. Also cannot run due to chord issues.
Cannot run this but there seem to be lots of line breaks in the footer display. As the footer area is small this will not be displayed and lead to forum comments.
You need some validation do defend against too long footers!